improve tests

Author: jribbink

internal/dependencymanager/dependencyinstaller_test.go

@@ -2313,6 +2313,67 @@ func TestBlockHeightPinning(t *testing.T) {
 		assert.Equal(t, computeHash(newContractCode), updatedDep.Hash, "Should update to new version")
 	})
 
+	t.Run("SkipUpdatePromptsDoesNotErrorWhenOnChainDiffersFromFlowJson", func(t *testing.T) {
+		_, state, _ := util.TestMocks(t)
+
+		// What's in flow.json (old hash)
+		oldHash := "abc123old"
+
+		// What's on-chain at pinned block (hypothetically changed - shouldn't happen but testing edge case)
+		onChainCode := []byte("access(all) contract ChangedContract {}")
+
+		pinnedDep := config.Dependency{
+			Name:        "ChangedContract",
+			BlockHeight: 10000,
+			Hash:        oldHash, // flow.json has old hash
+			Source: config.Source{
+				NetworkName:  config.EmulatorNetwork.Name,
+				Address:      serviceAddress,
+				ContractName: "ChangedContract",
+			},
+		}
+		state.Dependencies().AddOrUpdate(pinnedDep)
+
+		gw := mocks.DefaultMockGateway()
+		gw.GetLatestBlock.Return(&flow.Block{
+			BlockHeader: flow.BlockHeader{Height: 50000},
+		}, nil)
+
+		// On-chain returns different contract (hash mismatch)
+		gw.GetAccountAtBlockHeight.Run(func(args mock.Arguments) {
+			acc := tests.NewAccountWithAddress(serviceAddress.String())
+			acc.Contracts = map[string][]byte{
+				"ChangedContract": onChainCode, // Different from flow.json hash!
+			}
+			gw.GetAccountAtBlockHeight.Return(acc, nil)
+		})
+
+		di := &DependencyInstaller{
+			Gateways: map[string]gateway.Gateway{
+				config.EmulatorNetwork.Name: gw.Mock,
+			},
+			Logger:            logger,
+			State:             state,
+			SaveState:         false,
+			TargetDir:         "",
+			SkipDeployments:   true,
+			SkipAlias:         true,
+			SkipUpdatePrompts: true, // --skip-update-prompts
+			dependencies:      make(map[string]config.Dependency),
+			logs:              categorizedLogs{},
+			prompter:          &mockPrompter{responses: []bool{}},
+		}
+
+		// Key test: Should NOT error even though on-chain hash differs
+		// With no file, it installs the on-chain version
+		err := di.Add(pinnedDep)
+		assert.NoError(t, err, "Should not error when on-chain differs from flow.json with --skip-update-prompts")
+
+		// Should install the on-chain version (new hash)
+		savedDep := state.Dependencies().ByName("ChangedContract")
+		assert.Equal(t, computeHash(onChainCode), savedDep.Hash, "Should install on-chain version when no local file")
+	})
+
 	t.Run("BlockHeightFetchFailureReturnsError", func(t *testing.T) {
 		_, state, _ := util.TestMocks(t)