Merge pull request #1989 from ianlv/master

refactor: replace []byte(fmt.Sprintf) with fmt.Appendf

Author: chasefleming

internal/command/command.go

@@ -375,7 +375,7 @@ func UsageMetrics(command *cobra.Command, wg *sync.WaitGroup) {
 
 	// calculates a user ID that doesn't leak any personal information
 	usr, _ := user.Current() // ignore err, just use empty string
-	hash := sha256.Sum256([]byte(fmt.Sprintf("%s%s", usr.Username, usr.Uid)))
+	hash := sha256.Sum256(fmt.Appendf(nil, "%s%s", usr.Username, usr.Uid))
 	userID := base64.StdEncoding.EncodeToString(hash[:])
 
 	_ = client.Track(userID, "cli-command", &mixpanel.Event{

internal/emulator/start.go

@@ -112,7 +112,7 @@ func trackRequestMiddleware(next http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		// Generate a unique user ID
 		usr, _ := user.Current() // ignore err, just use empty string
-		hash := sha256.Sum256([]byte(fmt.Sprintf("%s%s", usr.Username, usr.Uid)))
+		hash := sha256.Sum256(fmt.Appendf(nil, "%s%s", usr.Username, usr.Uid))
 		userID := base64.StdEncoding.EncodeToString(hash[:])
 
 		// Track the request in Mixpanel

internal/util/util.go

@@ -65,7 +65,7 @@ func AddToGitIgnore(filename string, loader flowkit.ReaderWriter) error {
 	}
 	return loader.WriteFile(
 		gitIgnorePath,
-		[]byte(fmt.Sprintf("%s\n%s", gitIgnoreFiles, filename)),
+		fmt.Appendf(nil, "%s\n%s", gitIgnoreFiles, filename),
 		filePermissions,
 	)
 }