refactor: use maps.Copy for cleaner map handling#1962
Merged
Conversation
cuinix
requested review from
Kay-Zee,
bjartek,
bluesign,
chasefleming,
janezpodhostnik,
jribbink,
mfbz and
nvdtf
as code owners
bjartek
approved these changes
May 15, 2025
Member
|
@cuinix looks like the CI is failing on this one |
Contributor
Author
Oh, indeed. Modified. I will keep an eye on the progress of CI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1962 +/- ##
=======================================
Coverage 25.81% 25.81%
=======================================
Files 96 96
Lines 6648 6644 -4
=======================================
- Hits 1716 1715 -1
+ Misses 4755 4753 -2
+ Partials 177 176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@cuinix looks like just a linting error now. |
Signed-off-by: cuinix <915115094@qq.com>
Contributor
Author
Oh, sorry, it's fixed. It was an issue with the package import in my IDE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize code using a more modern writing style.
For contributor use:
masterbranchFiles changedin the Github PR explorer