refactor: improve testability of context construction

Author: teoincontatto

stackgres-k8s/src/operator/src/main/java/io/stackgres/operator/conciliation/backup/context/BackupClusterContextAppender.java

@@ -37,26 +37,27 @@ public BackupClusterContextAppender(
   public void appendContext(StackGresBackup backup, Builder contextBuilder) {
     final String clusterNamespace = StackGresUtil.getNamespaceFromRelativeId(
         backup.getSpec().getSgCluster(), backup.getMetadata().getNamespace());
-    if (!clusterNamespace.equals(backup.getMetadata().getNamespace())) {
-      contextBuilder.foundCluster(Optional.empty());
-      return;
-    }
-
-    if (BackupStatus.isFinished(backup)) {
+    final String clusterName = StackGresUtil.getNameFromRelativeId(
+        backup.getSpec().getSgCluster());
+    if (BackupStatus.isFinished(backup)
+        && !StackGresUtil.isRelativeIdNotInSameNamespace(backup.getSpec().getSgCluster())) {
       contextBuilder.foundCluster(Optional.empty());
       return;
     }
 
     final Optional<StackGresCluster> foundCluster = clusterFinder
         .findByNameAndNamespace(
-            backup.getSpec().getSgCluster(),
-            backup.getMetadata().getNamespace());
+            clusterName,
+            clusterNamespace);
 
     contextBuilder.foundCluster(foundCluster);
 
     if (foundCluster.isEmpty()) {
+      if (StackGresUtil.isRelativeIdNotInSameNamespace(backup.getSpec().getSgCluster())) {
+        return;
+      }
       throw new IllegalArgumentException(
-          StackGresCluster.KIND + " " + backup.getSpec().getSgCluster() + " was not found");
+          StackGresCluster.KIND + " " + clusterName + " was not found");
     }
     final StackGresCluster cluster = foundCluster.get();
     backupClusterInstanceProfileContextAppender.appendContext(cluster, contextBuilder);

stackgres-k8s/src/operator/src/test/java/io/stackgres/operator/conciliation/backup/context/BackupClusterContextAppenderTest.java

@@ -7,6 +7,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
@@ -70,6 +71,19 @@ void givenBackupWithCluster_shouldPass() {
     verify(backupClusterObjectStorageContextAppender).appendContext(cluster, contextBuilder);
   }
 
+  @Test
+  void givenBackupCopyWithCluster_shouldPass() {
+    backup.getSpec().setSgCluster("test.test");
+    when(clusterFinder.findByNameAndNamespace(
+        "test",
+        "test"))
+        .thenReturn(Optional.of(cluster));
+    contextAppender.appendContext(backup, contextBuilder);
+    verify(contextBuilder).foundCluster(Optional.of(cluster));
+    verify(backupClusterInstanceProfileContextAppender).appendContext(cluster, contextBuilder);
+    verify(backupClusterObjectStorageContextAppender).appendContext(cluster, contextBuilder);
+  }
+
   @Test
   void givenBackupWithoutCluster_shouldFail() {
     when(clusterFinder.findByNameAndNamespace(
@@ -81,6 +95,17 @@ void givenBackupWithoutCluster_shouldFail() {
     assertEquals("SGCluster backup-with-default-storage was not found", ex.getMessage());
   }
 
+  @Test
+  void givenBackupCopyWithoutCluster_shouldPass() {
+    backup.getSpec().setSgCluster("test.test");
+    when(clusterFinder.findByNameAndNamespace("test", "test"))
+        .thenReturn(Optional.empty());
+    contextAppender.appendContext(backup, contextBuilder);
+    verify(contextBuilder).foundCluster(Optional.empty());
+    verify(backupClusterInstanceProfileContextAppender, Mockito.never()).appendContext(Mockito.any(), Mockito.any());
+    verify(backupClusterObjectStorageContextAppender, Mockito.never()).appendContext(Mockito.any(), Mockito.any());
+  }
+
   @Test
   void givenCompletedBackupWithoutCluster_shouldPass() {
     backup.setStatus(
@@ -98,13 +123,4 @@ void givenCompletedBackupWithoutCluster_shouldPass() {
     verify(backupClusterObjectStorageContextAppender, Mockito.never()).appendContext(Mockito.any(), Mockito.any());
   }
 
-  @Test
-  void givenBackupInAnotherNamespaceWithoutCluster_shouldPass() {
-    backup.getSpec().setSgCluster("test.test");
-    contextAppender.appendContext(backup, contextBuilder);
-    verify(contextBuilder).foundCluster(Optional.empty());
-    verify(backupClusterInstanceProfileContextAppender, Mockito.never()).appendContext(Mockito.any(), Mockito.any());
-    verify(backupClusterObjectStorageContextAppender, Mockito.never()).appendContext(Mockito.any(), Mockito.any());
-  }
-
 }