Skip to content

Commit 14f5c81

Browse files
committed
e2e: fix sharded cluster update to avoid repeat sgscripts references
1 parent 5125262 commit 14f5c81

2 files changed

Lines changed: 32 additions & 12 deletions

File tree

stackgres-k8s/e2e/utils/spec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,8 @@ run_spec() {
346346
fi
347347
"$FUNCTION"
348348
done
349-
if [ "$SPEC_VALUE" != none ]
349+
if [ "$SPEC_VALUE" != none ] \
350+
&& [ "$E2E_USE_TEST_CACHE_PER_TEST" = true ]
350351
then
351352
store_test_result "$SPEC_NAME" "$SPEC_VALUE"
352353
fi

stackgres-k8s/src/admin-ui/cypress/e2e/03-forms/10-create-sgshardedcluster.cy.js

Lines changed: 30 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,26 @@ describe('Create SGShardedCluster', () => {
3636
// Create SGScript
3737
cy.createCRD('sgscripts', {
3838
metadata: {
39-
name: 'script-' + resourceName,
39+
name: 'script-coord-' + resourceName,
40+
namespace: namespace
41+
},
42+
spec: {
43+
continueOnError: false,
44+
managedVersions: true,
45+
scripts: [
46+
{
47+
storeStatusInDatabase: false,
48+
retryOnError: false,
49+
script: resourceName
50+
}
51+
]
52+
}
53+
})
54+
55+
// Create SGScript
56+
cy.createCRD('sgscripts', {
57+
metadata: {
58+
name: 'script-shards-' + resourceName,
4059
namespace: namespace
4160
},
4261
spec: {
@@ -408,7 +427,7 @@ describe('Create SGShardedCluster', () => {
408427

409428
// Test Coordinator select script
410429
cy.get('[data-field="spec.coordinator.managedSql.scripts.scriptSource.coordinator[1]"]')
411-
.select('script-' + resourceName)
430+
.select('script-coord-' + resourceName)
412431

413432
// Test User-Supplied Pods Sidecars
414433
cy.get('form#createShardedCluster li[data-step="coordinator.sidecars"]')
@@ -1016,7 +1035,7 @@ describe('Create SGShardedCluster', () => {
10161035

10171036
// Test Shards select script
10181037
cy.get('[data-field="spec.shards.managedSql.scripts.scriptSource.shards[1]"]')
1019-
.select('script-' + resourceName)
1038+
.select('script-shards-' + resourceName)
10201039

10211040
// Test User-Supplied Pods Sidecars
10221041
cy.get('form#createShardedCluster li[data-step="shards.sidecars"]')
@@ -2211,7 +2230,7 @@ describe('Create SGShardedCluster', () => {
22112230
cy.get('@postCluster')
22122231
.its('request.body.spec.coordinator.managedSql')
22132232
.should('nested.include', {"scripts[0].scriptSpec.scripts[0].script": '' + resourceName})
2214-
.and('nested.include', {"scripts[1].sgScript": 'script-' + resourceName})
2233+
.and('nested.include', {"scripts[1].sgScript": 'script-coord-' + resourceName})
22152234
cy.get('@postCluster')
22162235
.its('request.body.spec.coordinator.pods')
22172236
.should('nested.include', {"customVolumes[0].name": 'vol1'})
@@ -2355,7 +2374,7 @@ describe('Create SGShardedCluster', () => {
23552374
cy.get('@postCluster')
23562375
.its('request.body.spec.shards.managedSql')
23572376
.should('nested.include', {"scripts[0].scriptSpec.scripts[0].script": '' + resourceName})
2358-
.and('nested.include', {"scripts[1].sgScript": 'script-' + resourceName})
2377+
.and('nested.include', {"scripts[1].sgScript": 'script-shards-' + resourceName})
23592378
cy.get('@postCluster')
23602379
.its('request.body.spec.shards.pods')
23612380
.should('nested.include', {"customVolumes[0].name": 'vol1'})
@@ -3178,7 +3197,7 @@ describe('Create SGShardedCluster', () => {
31783197

31793198
// Test Coordinator select script
31803199
cy.get('select[data-field="spec.coordinator.managedSql.scripts.scriptSource.coordinator[1]"]')
3181-
.should('have.value', 'script-' + resourceName)
3200+
.should('have.value', 'script-coord-' + resourceName)
31823201
cy.get('textarea[data-field="spec.coordinator.managedSql.scripts[1].scriptSpec.scripts[0].script"]')
31833202
.should('have.value', '' + resourceName)
31843203
.clear()
@@ -3757,7 +3776,7 @@ describe('Create SGShardedCluster', () => {
37573776

37583777
// Test Shards select script
37593778
cy.get('select[data-field="spec.shards.managedSql.scripts.scriptSource.shards[1]"]')
3760-
.should('have.value', 'script-' + resourceName)
3779+
.should('have.value', 'script-shards-' + resourceName)
37613780
cy.get('textarea[data-field="spec.shards.managedSql.scripts[1].scriptSpec.scripts[0].script"]')
37623781
.should('have.value', '' + resourceName)
37633782
.clear()
@@ -4213,7 +4232,7 @@ describe('Create SGShardedCluster', () => {
42134232
cy.get('@putCluster')
42144233
.its('request.body.spec.coordinator.managedSql')
42154234
.should('nested.include', {"scripts[0].scriptSpec.scripts[0].script": 'test-' + resourceName})
4216-
.and('nested.include', {"scripts[1].sgScript": 'script-' + resourceName})
4235+
.and('nested.include', {"scripts[1].sgScript": 'script-coord-' + resourceName})
42174236
.and('nested.include', {"scripts[1].scriptSpec.scripts[0].script": 'test2-' + resourceName})
42184237
.and('nested.include', {"scripts[2].scriptSpec.scripts[0].script": 'test3-' + resourceName})
42194238
cy.get('@putCluster')
@@ -4340,7 +4359,7 @@ describe('Create SGShardedCluster', () => {
43404359
cy.get('@putCluster')
43414360
.its('request.body.spec.shards.managedSql')
43424361
.should('nested.include', {"scripts[0].scriptSpec.scripts[0].script": 'test-' + resourceName})
4343-
.and('nested.include', {"scripts[1].sgScript": 'script-' + resourceName})
4362+
.and('nested.include', {"scripts[1].sgScript": 'script-shards-' + resourceName})
43444363
.and('nested.include', {"scripts[1].scriptSpec.scripts[0].script": 'test2-' + resourceName})
43454364
.and('nested.include', {"scripts[2].scriptSpec.scripts[0].script": 'test3-' + resourceName})
43464365
cy.get('@putCluster')
@@ -4529,7 +4548,7 @@ describe('Create SGShardedCluster', () => {
45294548
.click({force: true})
45304549

45314550
cy.get('select[data-field="spec.coordinator.managedSql.scripts.scriptSource.coordinator[0]"]')
4532-
.select('script-' + resourceName)
4551+
.select('script-coord-' + resourceName)
45334552

45344553
// Coordinator Add new Script
45354554
cy.get('.scriptFieldset > div.fieldsetFooter > a.addRow')
@@ -4558,7 +4577,7 @@ describe('Create SGShardedCluster', () => {
45584577
.click({force: true})
45594578

45604579
cy.get('select[data-field="spec.shards.managedSql.scripts.scriptSource.shards[0]"]')
4561-
.select('script-' + resourceName)
4580+
.select('script-shards-' + resourceName)
45624581

45634582
// Shards Add new Script
45644583
cy.get('.scriptFieldset > div.fieldsetFooter > a.addRow')

0 commit comments

Comments
 (0)