fix: wrong original SGStream service path in webhooks, avoid setting caBundle in webhooks, follow webhooks original ordering, avoid usage of nullable in CRDs

Author: teoincontatto

stackgres-k8s/e2e/utils/operator

@@ -844,6 +844,12 @@ before_operator_install_or_upgrade() {
 after_operator_install_or_upgrade() {
   kubectl label namespace "$OPERATOR_NAMESPACE" --overwrite monitoring=true
   wait_services_available "$OPERATOR_NAMESPACE" 1 '^stackgres-operator$'
+  wait_until eval 'kubectl get validatingwebhookconfigurations.admissionregistration.k8s.io stackgres-operator -o json \
+    | jq ".webhooks|any(.clientConfig.caBundle == null)" \
+    | grep -qxF false'
+  wait_until eval 'kubectl get mutatingwebhookconfigurations.admissionregistration.k8s.io stackgres-operator -o json \
+    | jq ".webhooks|any(.clientConfig.caBundle == null)" \
+    | grep -qxF false'
   wait_services_available "$OPERATOR_NAMESPACE" 1 '^stackgres-restapi$'
   wait_until eval 'kubectl get job -n "$OPERATOR_NAMESPACE" -l "app=StackGresConfig" -o name | wc -l | grep -qxF 0'
   if [ "$OPERATOR_FROM" != true ] && [ "$EXTENSIONS_CACHE_ENABLED" = true ]

stackgres-k8s/install/helm/stackgres-operator/templates/mutating-webhook-configuration.yaml

@@ -104,29 +104,6 @@ webhooks:
       matchLabels:
         {{ toYaml .Values.allowedNamespaceLabelSelector | nindent 8 }}
     {{- end }}
-  - name: sgbackupconfig.mutating-webhook.stackgres.io
-    sideEffects: None
-    rules:
-      - operations: ["CREATE", "UPDATE"]
-        apiGroups: ["stackgres.io"]
-        apiVersions: ["*"]
-        resources: ["sgbackupconfigs"]
-    failurePolicy: Fail
-    clientConfig:
-      service:
-        namespace: {{ .Release.Namespace }}
-        name: {{ .Release.Name }}
-        path: '/stackgres/mutation/sgbackupconfig'
-    admissionReviewVersions: ["v1"]
-    {{- if .Values.allowedNamespaces }}
-    namespaceSelector:
-      matchLabels:
-        stackgres.io/scope: {{ .Release.Namespace }}.{{ .Release.Name }}
-    {{- else if .Values.allowedNamespaceLabelSelector }}
-    namespaceSelector:
-      matchLabels:
-        {{ toYaml .Values.allowedNamespaceLabelSelector | nindent 8 }}
-    {{- end }}
   - name: sgbackup.mutating-webhook.stackgres.io
     sideEffects: None
     rules:

stackgres-k8s/install/helm/stackgres-operator/templates/validating-webhook-configuration.yaml

@@ -104,29 +104,6 @@ webhooks:
       matchLabels:
         {{ toYaml .Values.allowedNamespaceLabelSelector | nindent 8 }}
     {{- end }}
-  - name: sgbackupconfig.validating-webhook.stackgres.io
-    sideEffects: None
-    rules:
-      - operations: ["CREATE", "UPDATE", "DELETE"]
-        apiGroups: ["stackgres.io"]
-        apiVersions: ["*"]
-        resources: ["sgbackupconfigs"]
-    failurePolicy: Fail
-    clientConfig:
-      service:
-        namespace: {{ .Release.Namespace }}
-        name: {{ .Release.Name }}
-        path: '/stackgres/validation/sgbackupconfig'
-    admissionReviewVersions: ["v1"]
-    {{- if .Values.allowedNamespaces }}
-    namespaceSelector:
-      matchLabels:
-        stackgres.io/scope: {{ .Release.Namespace }}.{{ .Release.Name }}
-    {{- else if .Values.allowedNamespaceLabelSelector }}
-    namespaceSelector:
-      matchLabels:
-        {{ toYaml .Values.allowedNamespaceLabelSelector | nindent 8 }}
-    {{- end }}
   - name: sgbackup.validating-webhook.stackgres.io
     sideEffects: None
     rules: