fix: can not remove secretKeySelectors when useIamRole is true in SGObjectStorage

Author: teoincontatto

stackgres-k8s/src/operator/src/main/java/io/stackgres/operator/validation/objectstorage/ObjectStorageTypeValidator.java

@@ -38,7 +38,7 @@ public void validate(StackGresObjectStorageReview review) throws ValidationFaile
             fail("Invalid object storage. If storage type is s3, the s3 property must be set");
           }
           if (backupStorage.getS3() != null
-              && Optional.ofNullable(backupStorage.getS3())
+              && !Optional.ofNullable(backupStorage.getS3())
               .map(AwsS3Storage::getAwsCredentials)
               .map(AwsCredentials::getUseIamRole)
               .orElse(false)

stackgres-k8s/src/operator/src/test/java/io/stackgres/operator/validation/objectstorage/ObjectStorageTypeValidatorTest.java

@@ -8,6 +8,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
+import io.stackgres.common.crd.storages.AwsCredentials;
 import io.stackgres.common.crd.storages.AwsS3CompatibleStorage;
 import io.stackgres.common.crd.storages.AwsS3Storage;
 import io.stackgres.common.crd.storages.AzureBlobStorage;
@@ -103,6 +104,8 @@ void testUnwantedPropertiesSet() {
         + "If storage type is s3, neither s3Compatible, gcs or azureBlob must be set";
 
     review.getRequest().getObject().getSpec().setS3(new AwsS3Storage());
+    review.getRequest().getObject().getSpec().getS3().setAwsCredentials(new AwsCredentials());
+    review.getRequest().getObject().getSpec().getS3().getAwsCredentials().setUseIamRole(true);
 
     review.getRequest().getObject().getSpec().setS3Compatible(new AwsS3CompatibleStorage());
     assertObjectStorageReviewMessage(review, unwantedS3Message);
@@ -180,6 +183,8 @@ void testValidCreation() throws ValidationFailed {
     setType(review, "s3");
     setNullStorages(review);
     review.getRequest().getObject().getSpec().setS3(new AwsS3Storage());
+    review.getRequest().getObject().getSpec().getS3().setAwsCredentials(new AwsCredentials());
+    review.getRequest().getObject().getSpec().getS3().getAwsCredentials().setUseIamRole(true);
     validator.validate(review);
 
     setType(review, "s3Compatible");
@@ -206,6 +211,8 @@ void testValidUpdate() throws ValidationFailed {
     setType(review, "s3");
     setNullStorages(review);
     review.getRequest().getObject().getSpec().setS3(new AwsS3Storage());
+    review.getRequest().getObject().getSpec().getS3().setAwsCredentials(new AwsCredentials());
+    review.getRequest().getObject().getSpec().getS3().getAwsCredentials().setUseIamRole(true);
     validator.validate(review);
 
     setType(review, "s3Compatible");