fix: Files.list is not in a try-with-resources block

Author: teoincontatto

stackgres-k8s/src/common/src/main/java/io/stackgres/common/extension/ExtensionManager.java

@@ -198,19 +198,21 @@ public void installExtension() throws Exception {
     }
 
     public void createExtensionLinks() throws Exception {
-      fileSystemHandler
-          .list(Paths.get(ClusterPath.PG_EXTENSIONS_LIB_PATH.path(context)))
-          .map(libFile -> Tuple.tuple(libFile,
-              Paths.get(ClusterPath.PG_RELOCATED_LIB_PATH.path(context))
-                  .resolve(libFile.getFileName())))
-          .forEach(
-              Unchecked.consumer(t -> {
-                Path targetParent = t.v2.getParent();
-                if (targetParent != null) {
-                  fileSystemHandler.createDirectories(targetParent);
-                }
-                fileSystemHandler.createOrReplaceSymbolicLink(t.v2, t.v1);
-              }));
+      try (var list = fileSystemHandler
+          .list(Paths.get(ClusterPath.PG_EXTENSIONS_LIB_PATH.path(context)))) {
+        list
+            .map(libFile -> Tuple.tuple(libFile,
+                Paths.get(ClusterPath.PG_RELOCATED_LIB_PATH.path(context))
+                    .resolve(libFile.getFileName())))
+            .forEach(
+                Unchecked.consumer(t -> {
+                  Path targetParent = t.v2.getParent();
+                  if (targetParent != null) {
+                    fileSystemHandler.createDirectories(targetParent);
+                  }
+                  fileSystemHandler.createOrReplaceSymbolicLink(t.v2, t.v1);
+                }));
+      }
       fileSystemHandler.createOrReplaceFile(
           Paths.get(ClusterPath.PG_RELOCATED_LIB_PATH.path(context))
           .resolve(packageName + LINKS_CREATED_SUFFIX));

stackgres-k8s/src/common/src/main/java/io/stackgres/common/patroni/PatroniCtlBinaryInstance.java

@@ -132,13 +132,14 @@ final String patroniCtlCommand(String version) {
       patroniMajorVersion = 3;
     }
     final String patroniVersionPrefix = PATRONICTL_BINARY_PREFIX_PATH + patroniMajorVersion + ".";
-    var pathFound = Unchecked.supplier(() -> Files.list(Paths.get(BIN_PATH)))
-        .get()
-        .filter(path -> path.getFileName().toString().startsWith(patroniVersionPrefix))
-        .sorted(new PatroniCtlPathComparator().reversed())
-        .findFirst();
-    if (pathFound.isPresent()) {
-      return pathFound.get().toAbsolutePath().toString();
+    try (var list = Unchecked.supplier(() -> Files.list(Paths.get(BIN_PATH))).get()) {
+      var pathFound = list
+          .filter(path -> path.getFileName().toString().startsWith(patroniVersionPrefix))
+          .sorted(new PatroniCtlPathComparator().reversed())
+          .findFirst();
+      if (pathFound.isPresent()) {
+        return pathFound.get().toAbsolutePath().toString();
+      }
     }
     throw new RuntimeException("No patronictl binary found for version " + version);
   }