test: fixed broked tests

Author: teoincontatto

stackgres-k8s/src/operator/src/main/java/io/stackgres/operator/conciliation/cluster/context/ClusterPostgresVersionContextAppender.java

@@ -179,7 +179,7 @@ public void appendContext(StackGresCluster cluster, Builder contextBuilder) {
         .getBuildVersion(postgresVersion);
 
     if (BUGGY_PG_VERSIONS.keySet().contains(version)
-        && Objects.equals(Optional.of(version), previousVersion)) {
+        && !Objects.equals(Optional.of(version), previousVersion)) {
       throw new IllegalArgumentException(
           "Do not use PostgreSQL " + version + ". "
               + BUGGY_PG_VERSIONS.get(version));

stackgres-k8s/src/operator/src/main/java/io/stackgres/operator/conciliation/factory/cluster/PostgresSslSecret.java

@@ -43,7 +43,7 @@ public class PostgresSslSecret
 
   private static final Duration ONE_DAY = Duration.ofDays(1);
 
-  private static final long DEFAULT_DURATION = 13 * 30;
+  private static final long DEFAULT_DURATION = 365;
 
   private static final String SSL_SUFFIX = "-ssl";
 

stackgres-k8s/src/operator/src/test/java/io/stackgres/operator/conciliation/factory/cluster/PostgresSslSecretTest.java

@@ -16,6 +16,8 @@
 import java.security.interfaces.RSAPrivateCrtKey;
 import java.security.spec.PKCS8EncodedKeySpec;
 import java.security.spec.RSAPublicKeySpec;
+import java.time.Duration;
+import java.time.Instant;
 import java.util.Base64;
 import java.util.Optional;
 
@@ -26,6 +28,7 @@
 import io.stackgres.common.fixture.Fixtures;
 import io.stackgres.common.labels.ClusterLabelFactory;
 import io.stackgres.common.labels.ClusterLabelMapper;
+import io.stackgres.operator.common.CryptoUtil;
 import io.stackgres.operator.conciliation.cluster.StackGresClusterContext;
 import io.stackgres.operatorframework.resource.ResourceUtil;
 import org.junit.jupiter.api.Assertions;
@@ -110,12 +113,15 @@ void givenAClusterWithSslAndNoSecret_itShouldGenerateSslSecret() throws Exceptio
   }
 
   @Test
-  void givenAClusterWithSslAndSecret_itShouldReuseSslSecret() {
+  void givenAClusterWithSslAndSecret_itShouldReuseSslSecret() throws Exception {
     cluster.getSpec().getPostgres().setSsl(new StackGresClusterSsl());
     cluster.getSpec().getPostgres().getSsl().setEnabled(true);
     when(context.getSource()).thenReturn(cluster);
-    when(context.getPostgresSslCertificate()).thenReturn(Optional.of("test-certificate"));
-    when(context.getPostgresSslPrivateKey()).thenReturn(Optional.of("test-private-key"));
+    var generated = CryptoUtil.generateCertificateAndPrivateKey(Instant.now().plus(Duration.ofDays(365)));
+    final String cert = generated.v1;
+    when(context.getPostgresSslCertificate()).thenReturn(Optional.of(cert));
+    final String key = generated.v2;
+    when(context.getPostgresSslPrivateKey()).thenReturn(Optional.of(key));
 
     var secretVolumePairs = postgresSslSecret.buildVolumes(context).toList();
 
@@ -130,7 +136,7 @@ void givenAClusterWithSslAndSecret_itShouldReuseSslSecret() {
         .map(Secret::getData)
         .map(data -> data.get(PatroniUtil.CERTIFICATE_KEY))
         .isPresent());
-    Assertions.assertEquals("test-certificate",
+    Assertions.assertEquals(cert,
         ResourceUtil.decodeSecret(
         secretVolumePairs.getFirst().getSource()
         .map(Secret.class::cast)
@@ -142,7 +148,7 @@ void givenAClusterWithSslAndSecret_itShouldReuseSslSecret() {
         .map(Secret::getData)
         .map(data -> data.get(PatroniUtil.PRIVATE_KEY_KEY))
         .isPresent());
-    Assertions.assertEquals("test-private-key",
+    Assertions.assertEquals(key,
         ResourceUtil.decodeSecret(
         secretVolumePairs.getFirst().getSource()
         .map(Secret.class::cast)

stackgres-k8s/src/operator/src/test/java/io/stackgres/operator/validation/dbops/DbOpsMajorVersionUpgradeValidatorTest.java

@@ -5,7 +5,7 @@
 
 package io.stackgres.operator.validation.dbops;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.Assert.assertTrue;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import io.stackgres.operator.common.StackGresDbOpsReview;
@@ -42,11 +42,7 @@ void givenBuggyVersionOnCreation_shouldFail() {
 
     String resultMessage = ex.getMessage();
 
-    assertEquals("Do not use PostgreSQL " + BUGGY_VERSION + ". Please, use PostgreSQL 14.4 since it fixes"
-        + " an issue with CREATE INDEX CONCURRENTLY and REINDEX CONCURRENTLY"
-        + " that could cause silent data corruption of indexes. For more info see"
-        + " https://www.postgresql.org/about/news/postgresql-144-released-2470/.",
-        resultMessage);
+    assertTrue(resultMessage, resultMessage.startsWith("Do not use PostgreSQL " + BUGGY_VERSION + "."));
   }
 
   private StackGresDbOpsReview getCreationReview() {

stackgres-k8s/src/operator/src/test/java/io/stackgres/operator/validation/shardeddbops/ShardedDbOpsMajorVersionUpgradeValidatorTest.java

@@ -5,7 +5,7 @@
 
 package io.stackgres.operator.validation.shardeddbops;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.Assert.assertTrue;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import io.stackgres.operator.common.StackGresShardedDbOpsReview;
@@ -42,11 +42,7 @@ void givenBuggyMajorVersionOnCreation_shouldFail() {
 
     String resultMessage = ex.getMessage();
 
-    assertEquals("Do not use PostgreSQL " + BUGGY_VERSION + ". Please, use PostgreSQL 14.4 since it"
-        + " fixes an issue with CREATE INDEX CONCURRENTLY and REINDEX CONCURRENTLY that could cause"
-        + " silent data corruption of indexes. For more info see"
-        + " https://www.postgresql.org/about/news/postgresql-144-released-2470/.",
-        resultMessage);
+    assertTrue(resultMessage, resultMessage.startsWith("Do not use PostgreSQL " + BUGGY_VERSION + "."));
   }
 
   private StackGresShardedDbOpsReview getCreationReview() {

stackgres-k8s/src/test-util/src/main/resources/stackgres/pooling_config/from_version1.json

@@ -28,7 +28,6 @@
         "application_name_add_host": "1",
         "auth_query": "SELECT usename, passwd FROM pg_shadow WHERE usename=$1",
         "auth_type": "md5",
-        "auth_user": "authenticator",
         "default_pool_size": "1000",
         "ignore_startup_parameters": "extra_float_digits",
         "max_client_conn": "1000",

stackgres-k8s/src/test-util/src/main/resources/stackgres/pooling_config/to_version1.json

@@ -28,7 +28,6 @@
         "application_name_add_host": "1",
         "auth_query": "SELECT usename, passwd FROM pg_shadow WHERE usename=$1",
         "auth_type": "md5",
-        "auth_user": "authenticator",
         "default_pool_size": "1000",
         "ignore_startup_parameters": "extra_float_digits",
         "max_client_conn": "1000",

stackgres-k8s/src/test-util/src/main/resources/stackgres/pooling_config/to_version1beta1.json

@@ -29,7 +29,6 @@
         "auth_query",
         "application_name_add_host",
         "max_user_connections",
-        "auth_user",
         "admin_users",
         "server_check_query"
       ]