Skip to content

Commit adb34db

Browse files
committed
refactor: improve testability of context construction
1 parent f47abbb commit adb34db

1 file changed

Lines changed: 0 additions & 33 deletions

File tree

stackgres-k8s/e2e/spec/restore

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@ e2e_test() {
126126

127127
run_test "Check that restore using PITR" check_restore_using_pitr
128128

129-
run_test "Check that backup is compatible with cluster" check_backup_pg_version
130-
131129
run_test "Check that after deleting original backup the backup is not deleted if a copy exists" \
132130
check_delete_original_backup_dont_delete_backup_if_copy_exists
133131

@@ -393,37 +391,6 @@ check_restore_using_pitr() {
393391
fi
394392
}
395393

396-
check_backup_pg_version() {
397-
ALTERNATIVE_PG_VERSION="12.9"
398-
if [ "${E2E_POSTGRES_VERSION%.*}" = "${ALTERNATIVE_PG_VERSION%.*}" ]
399-
then
400-
ALTERNATIVE_PG_VERSION="13.5"
401-
fi
402-
403-
local RESULT EXIT_CODE
404-
try_function create_or_replace_cluster "$ALTER_CLUSTER_NAME" "$CLUSTER_NAMESPACE" 1 \
405-
--set instanceProfiles=null \
406-
--set-string "cluster.configurations.sgPostgresConfig=alter-postgresconf" \
407-
--set-string "cluster.configurations.sgPoolingConfig=alter-pgbouncerconf" \
408-
--set-string "cluster.postgres.version=$ALTERNATIVE_PG_VERSION" \
409-
--set cluster.initialData.restore.fromBackup.name="$BACKUP_NAME" 2> "$LOG_PATH/create-alter-cluster.log"
410-
411-
if "$RESULT"
412-
then
413-
echo "ERROR: It should not be able to install a cluster with postgres version that is different than the backup pg version"
414-
return 1
415-
else
416-
success "Cluster was not created"
417-
fi
418-
419-
if grep -q "Cannot restore from SGBackup $BACKUP_NAME" "$LOG_PATH/create-alter-cluster.log"
420-
then
421-
success "Error message was the expected"
422-
else
423-
fail "Unexpected error message $ERROR_MESSAGE"
424-
fi
425-
}
426-
427394
check_delete_original_backup_dont_delete_backup_if_copy_exists() {
428395
BACKUP_INTERNAL_NAME="$(kubectl get sgbackups.stackgres.io -n "$BACKUP_CLUSTER_NAMESPACE" "$BACKUP_SOURCE_NAME"\
429396
--template '{{ .status.internalName }}')"

0 commit comments

Comments
 (0)