feat: remove reference validation

Author: teoincontatto

stackgres-k8s/e2e/spec/objectstorage-removal

@@ -24,30 +24,20 @@ e2e_test() {
 }
 
 delete_with_cluster() {
-  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" sgobjectstorages.stackgres.io backupconf 2>&1)"
+  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" --dry-run=server sgobjectstorages.stackgres.io backupconf 2>&1)"
   then
-    fail "It should not be able to delete sgobjectstorage"
-  else
-    success "Good it has failed"
-  fi
-
-  if echo "$ERROR" | grep -q "Can't delete sgobjectstorages.stackgres.io backupconf"
-  then
-    success "Error message was the expected"
-    return 0
+    success "Good. It has deleted the configuration"
   else
-    ERROR="$(cat "$LOG_PATH/test1.log")"
-    fail "Error is not what it should be. ERROR ${ERROR}"
+    fail "It should be able to delete the posgresconf. ERROR ${ERROR}"
   fi
 }
 
 delete_whitout_cluster() {
   kubectl get -n "$CLUSTER_NAMESPACE" sgclusters.stackgres.io "$CLUSTER_NAME" -o yaml | kubectl delete -f -
 
-  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" sgobjectstorages.stackgres.io backupconf 2>&1)"
+  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" --dry-run=server sgobjectstorages.stackgres.io backupconf 2>&1)"
   then
     success "Good. It has deleted the configuration"
-    return 0
   else
     fail "It should be able to delete the posgresconf. ERROR ${ERROR}"
   fi

stackgres-k8s/e2e/spec/operator-pgconfig-api

@@ -333,22 +333,9 @@ test_constraint_violation_api_error() {
 
   local HTTP_STATUS
 
-  HTTP_STATUS="$(run_curl -r "stackgres/sgpgconfigs" -n "$CLUSTER_NAMESPACE"  -d "$LOG_PATH/invalid-pgconfig.json" -e '-X POST -w %{http_code} -o /dev/null')"
+  HTTP_STATUS="$(run_curl -r "stackgres/sgpgconfigs" -n "$CLUSTER_NAMESPACE" -d "$LOG_PATH/invalid-pgconfig.json" -e '-X POST -w %{http_code} -o /dev/null')"
 
-  assert_string_equal "422" "$HTTP_STATUS"
-
-  ERROR_RESPONSE="$(run_curl -r "stackgres/sgpgconfigs" -n "$CLUSTER_NAMESPACE" -d "$LOG_PATH/invalid-pgconfig.json" -e '-X POST')"
-
-  EXPECTED_ERROR_TYPE="constraint-violation"
-  EXPECTED_ERROR_TITLE="do not comply with the syntactic rules"
-  EXPECTED_ERROR_DETAIL="spec.postgresVersion in body"
-  EXPECTED_ERROR_FIELD="postgresVersion"
-
-  if ! assert_api_error "$ERROR_RESPONSE"
-  then
-    EXPECTED_ERROR_DETAIL="Required value"
-    assert_api_error "$ERROR_RESPONSE"
-  fi
+  assert_string_equal "200" "$HTTP_STATUS"
 }
 
 test_authentication_api_error() {

stackgres-k8s/e2e/spec/operator-pgpooling-api

@@ -336,25 +336,14 @@ test_api_delete_pgpooling_is_invible() {
 }
 
 test_dependency_api_error(){
-
   remove_cluster "$CLUSTER_NAME" "$CLUSTER_NAMESPACE"
   create_or_replace_cluster "$CLUSTER_NAME" "$CLUSTER_NAMESPACE" 1
 
   local HTTP_STATUS
 
   HTTP_STATUS="$(run_curl -r "stackgres/sgpoolconfigs" -n "$CLUSTER_NAMESPACE" -d "$LOG_PATH/default-pgpooling.json" -e '-X DELETE -w %{http_code} -o /dev/null')"
 
-  assert_string_equal "409" "$HTTP_STATUS"
-
-  ERROR_RESPONSE="$(run_curl -r "stackgres/sgpoolconfigs" -n "$CLUSTER_NAMESPACE" -d "$LOG_PATH/default-pgpooling.json" -e '-X DELETE')"
-
-  EXPECTED_ERROR_TYPE="forbidden-configuration-deletion"
-  EXPECTED_ERROR_TITLE="Forbidden configuration deletion"
-  EXPECTED_ERROR_DETAIL="Can't delete sgpoolconfigs.stackgres.io $PGPOOLING"
-  EXPECTED_ERROR_FIELD=""
-
-  assert_api_error "$ERROR_RESPONSE"
-
+  assert_string_equal "204" "$HTTP_STATUS"
 }
 
 test_authentication_api_error() {
@@ -390,4 +379,4 @@ check_authentication_error() {
     echo "Request returned unexpected response status $HTTP_STATUS instead of the expected authentication error."
     return 1
   fi
-}
+}

stackgres-k8s/e2e/spec/pgbouncer-removal

@@ -15,35 +15,21 @@ e2e_test() {
 }
 
 delete_with_cluster() {
-  if ERROR_MESSAGE="$( { kubectl delete -n "$CLUSTER_NAMESPACE" sgpoolconfigs.stackgres.io pgbouncerconf; } 2>&1 )"
+  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" --dry-run=server sgpoolconfigs.stackgres.io pgbouncerconf)"
   then
-    echo "ERROR: It should not be able to delete pgbouncerconf"
-    return 1
-  else
-    success "Good it has failed"
-  fi
-  
-  echo "$ERROR_MESSAGE" > "${LOG_PATH}/test1.log"
-
-  if grep -q "Can't delete sgpoolconfigs.stackgres.io pgbouncerconf" "$LOG_PATH/test1.log"
-  then
-    success "Error message was the expected"
-    return 0
+    success "Good. It has deleted the configuration"
   else
-    ERROR="$(cat "$LOG_PATH/test1.log")"
-    fail "Error is not what it should be. ERROR: ${ERROR}"
+    fail "It should be able to delete the pgbouncerconf. ERROR $ERROR"
   fi
 }
 
 delete_whitout_cluster() {
   kubectl get -n "$CLUSTER_NAMESPACE" sgclusters.stackgres.io "$CLUSTER_NAME" -o yaml | kubectl delete -f - > /dev/null
 
-  if kubectl delete -n "$CLUSTER_NAMESPACE" sgpoolconfigs.stackgres.io pgbouncerconf
+  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" --dry-run=server sgpoolconfigs.stackgres.io pgbouncerconf)"
   then
     success "Good. It has deleted the configuration"
-    return 0
   else
-    ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" sgpoolconfigs.stackgres.io pgbouncerconf)"
     fail "It should be able to delete the pgbouncerconf. ERROR $ERROR"
   fi
 }

stackgres-k8s/e2e/spec/pgconfig-removal

@@ -15,31 +15,20 @@ e2e_test() {
 }
 
 delete_with_cluster() {
-  if ERROR_MESSAGE="$(kubectl delete -n "$CLUSTER_NAMESPACE" sgpgconfigs.stackgres.io postgresconf 2>&1)"
+  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" --dry-run=server sgpgconfigs.stackgres.io postgresconf 2>&1)"
   then
-    fail "It should not be able to delete sgspconfig"
-  else
-    success "Good it has failed"
-  fi
-
-  echo "$ERROR_MESSAGE" > "$LOG_PATH/test1.log"
-  if grep -q "Can't delete sgpgconfigs.stackgres.io postgresconf" "$LOG_PATH/test1.log"
-  then
-    success "Error message was the expected"
-    return 0
+    success "Good. It has deleted the configuration"
   else
-    ERROR="$(cat "$LOG_PATH/test1.log")"
-    fail "Error is not what it should be. ERROR ${ERROR}"
+    fail "It should be able to delete the posgresconf. ERROR ${ERROR}"
   fi
 }
 
 delete_whitout_cluster() {
   kubectl get -n "$CLUSTER_NAMESPACE" sgclusters.stackgres.io "$CLUSTER_NAME" -o yaml | kubectl delete -f -
 
-  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" sgpgconfigs.stackgres.io postgresconf 2>&1)"
+  if ERROR="$(kubectl delete -n "$CLUSTER_NAMESPACE" --dry-run=server sgpgconfigs.stackgres.io postgresconf 2>&1)"
   then
     success "Good. It has deleted the configuration"
-    return 0
   else
     fail "It should be able to delete the posgresconf. ERROR ${ERROR}"
   fi