Unicorn scroll edits improvement#3084
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdjusts hero-area pointer-event layering, adds a non-passive wheel listener to the unicorn background to translate wheel deltas into window scroll, and changes global CSS to allow vertical scrolling via body overflow-y. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/web/client/src/app/_components/hero/unicorn-background.tsx`:
- Around line 10-30: The wheel handler is causing double-scrolling because it's
added with { passive: true} so preventDefault can't be used; update the
useEffect to add the existing handleWheel listener with { passive: false } and
call e.preventDefault() at the top of the handleWheel function (referencing
handleWheel and containerRef in the useEffect) so the handler exclusively drives
scrolling, and ensure the same handleWheel function reference is removed in the
cleanup; alternatively, remove the custom handler and rely on Unicorn.Studio SDK
attributes (e.g., data-us-disablemobile) or CSS touch-action to control scroll
behavior.
|
Приветствую,что означает общая ветка?
чт, 22 янв. 2026 г., 04:01 Daniel R Farrell ***@***.***>:
… Merged #3084 <#3084> into main.
—
Reply to this email directly, view it on GitHub
<#3084 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXA63AURJUA4TI47TPE5N634IAAMPAVCNFSM6AAAAACSOZPRPCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSGIYDCMRTGA2DONA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Description
Fixes broken scrolling
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Fixes scrolling and pointer event issues in hero section and updates global styles for improved scroll behavior.
index.tsx, addedpointer-events-noneandpointer-events-autoclasses to manage pointer events in the hero section.unicorn-background.tsx, added a wheel event listener to handle scrolling while maintaining mouse interactivity.globals.cssto setoverscroll-behaviortononeforhtmlandbody, and adjustedoverflowproperties for better scroll experience.This description was created by
for d9beee4. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Bug Fixes
Enhancements
Style
✏️ Tip: You can customize this high-level summary in your review settings.