Commit a5e69ca
feat(training): GPU-resident fused step for non-TS single-net models (#1843)
* feat(training): gPU-resident fused step for non-TS single-net models
Kicks off the non-time-series GPU-residency sweep. Adds a shared helper for
classes that don't inherit from NeuralNetworkBase or TimeSeriesModelBase but
still want their Train() to route forward + backward + optimizer through the
compiled fused plan (weights / activations / Adam moments resident on-device
across the whole step).
* src/Training/GpuResidentFusedStep.cs — shared helper. TryResolveOptimizerConfig
maps a runtime IGradientBasedOptimizer to the fused-plan OptimizerType +
hyperparameters (Adam / AdamW / SGD supported via case-insensitive class-name
match + reflection over Options.InitialLearningRate / Beta1 / Beta2 / Epsilon
/ WeightDecay). TryStep is the one-shot entry.
Wired the following single-net models through the helper (mirrors
NeuralNetworkBase.TrainWithFusedStep):
* GraphClassificationModel (NN base + GNN + pooling + cross-entropy) —
routes tape training through the fused plan when float + DirectGpu +
compilation are live; falls through to the existing eager tape+optimizer
loop on any failure.
* LinkPredictionModel (NN base + GNN + node embeddings + BCE) — same
wire-up as GraphClassificationModel.
* FourierNeuralOperator (lift → FourierLayers → project, hardcoded SGD +
learning rate 0.001) — captures the whole spectral-conv chain in a fused
SGD plan; falls through to the in-place SGD loop below.
GAN-family generators (CTGAN, DPCTGAN, PATEGAN, ...), CLAPModel (learned
scalar outside layer hierarchy), AutoDiffTabGenerator (per-sample variable
shape defeats plan replay) and other non-conforming shapes are queued for
follow-up commits. The shared helper is the common seam so they all wire
the same way once their per-step structure fits the fused-plan contract
(constant shape + Adam/AdamW/SGD optimizer + ITrainableLayer-carried params).
Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): gPU-resident fused step for Finance foundation forecasters
Wires TFC, TOTEM, CSDI, MQCNN through the compiled fused SGD plan (all four use
in-place SGD with lr=0.001 as their eager path). Extends the shared helper with
an inline IsGpuResidentAvailable check so callers don't need to duplicate the
availability gate.
* GpuResidentFusedStep — adds IsGpuResidentAvailable static property (mirrors
TimeSeriesModelBase.CanTrainOnGpu / NeuralNetworkBase.CanTrainOnGpu). TryStep
short-circuits when unavailable so callers stay on their eager path.
* TFC — supervised + contrastive branches fused into one closure; the fused
plan captures both losses in a single backward.
* TOTEM — reconstruction + VQ commitment terms fused; the recompute-loss
closure re-derives the commitment loss on each replay for graph parity.
* CSDI — denoising-score-matching: the forward closure re-samples timestep +
noise each step (via ComputeDenoisingPairTape) so replay produces fresh
training data even though the plan's captured graph shape is fixed.
* MQCNN — multi-quantile pinball loss captured directly via ComputeMultiQuantilePinballLossTape.
All four fall through to the existing in-place SGD path on any fused-plan failure
(unsupported op, non-compilable graph, etc). Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): gPU-resident fused generator step for GAN-family synthetic generators + TVAE
Wires the generator side of the dual-network training loop through the fused
compiled plan for 9 SyntheticData generators. Each covers a distinct pattern:
* PATEGAN — per-sample loop; fused plan compiles on first sample, replays
across the batch with fresh noise per iteration.
* MedSynth — batched noise -> decoder -> discriminator-frozen -> non-saturating
log-sigmoid loss.
* CausalGAN — batched noise -> generator -> optional causal-structure ->
output activations -> disc-frozen -> -avgFake.
* OCTGAN — per-sample loop; noise -> gen -> disc-frozen embedding -> SVDD dist².
* TableGAN — noise + real batch -> gen -> composite loss (fake-scores +
information-loss + optional classification).
* CTGAN — the tricky one: pack (noise, cond, mask) into one persistent input
tensor so the closure can slice cond and mask back out on replay; captures
both -avgFake AND conditional cross-entropy on the fused plan.
* DPCTGAN — same pattern as CTGAN but simpler (no mask, no CE).
* CopulaGAN — same pattern as DPCTGAN.
* TVAE — encoder + reparam + decoder + composite ELBO (recon + KL) all fused;
Reparameterize re-samples inside the closure so training stays stochastic.
Discriminator/critic/student layers are NOT passed to the fused step (their
weights stay frozen on the gen step, matching the eager path semantics).
Falls through to the eager tape+optimizer path on any failure.
The discriminator STEPS of these GANs are not yet wired — they need a separate
pass because their loss involves gradient penalty (WGAN-GP) or per-example DP
clipping (DPCTGAN) which don't compose cleanly with the single-closure fused
step yet.
Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): gPU-resident fused step for TabSyn VAE + MisGAN mask/data gens
Two more SyntheticData generators covered — each covers a distinct pattern:
* TabSyn.TrainVAEBatch — per-row VAE ELBO training. Fused plan compiles on
first row, replays across the batch with refreshed input per iteration.
Reparameterize re-samples inside the closure so training stays stochastic.
* MisGAN.TrainDataGeneratorStep — dual-noise generator (data noise + mask
noise) packed into a single persistent input tensor; closure slices them
back out on replay. Loss = -E[D_x(fakeRow ⊙ fakeMask)].
* MisGAN.TrainMaskGeneratorStep — simpler single-noise version; per-sample
loop with fused plan replay across the batch.
The DataDiscriminator step (WGAN-style critic + weight clipping) and mask
discriminator step aren't wired — they need separate plans and the
ClipWeights post-step interacts poorly with the fused optimizer's
in-place update. Follow-up.
Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): gPU-resident fused step for TimeGAN P1/P2 + MedSynth non-DP disc
* TimeGAN Phase 1 (TrainReconstructionStepBatched) — embedder + recovery
reconstruction MSE. Straight single-network fused-step conversion.
* TimeGAN Phase 2 (TrainSupervisedStepBatched) — supervisor's next-step MSE
in the embedded space, with the embedder frozen (its layers not in the
trainable set for this step). Two-tensor closure (ht, htNext).
* MedSynth non-DP disc step — pack (real, fake) into a single input tensor
along axis 0; slice back in the loss for BCE-real + BCE-fake. Generator
runs OUTSIDE the fused plan so its weights stay frozen on the critic step.
TimeGAN Phase 3 (adversarial + supervised joint) and MedSynth DP-SGD paths
still use their eager tape — the WGAN-GP gradient penalty and per-example
DP clipping don't compose with the single-closure fused optimizer step.
Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): extra-tensors parameter on fused-step API
Extends the fused compiled-plan training step to accept raw trainable tensors
that aren't naturally carried by an ITrainableLayer (e.g. GOGGLE's soft
adjacency A; CLAP's learned _logTemperature scalar). Solves the SOLID
concerns raised in review of the ITrainableLayer-wrapper alternative:
* ISP — no forcing raw tensors to implement the full ILayer surface with
no-op Forward / SetTrainingMode / GetParameterGradients members
* LSP — no risk of "layer" wrappers with identity Forward diverging from
the layer contract's behavioral expectations elsewhere in the codebase
Wire-up:
* CompiledTapeTrainingStep.TryStepWithFusedOptimizer — new optional
extraTensors param. Threaded into the dedup-aware parameter collection
(CollectDeduplicatedParametersWithExtras) so extras get moment buffers,
gradient accumulation, and GPU-residency in exactly the same code path
that layer-carried params do.
* GpuResidentFusedStep.TryStep — plumbs extras through. A callsite with
only extras (no layers) is a valid config for models whose whole
trainable surface is raw tensors.
Dedup is by Tensor<T> reference across BOTH sources, so an extra tensor
that also happens to be layer-carried is registered exactly once — the
same shared/tied-weight protection the layer-only collector provides.
Enables Phase 4E (GOGGLE + CLAP wire-ups).
Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): wire GOGGLE + CLAP through fused-step extra-tensors API
Consumes Phase 4A's extraTensors parameter to route models with raw
trainable state (outside the ITrainableLayer contract) through the fused
compiled plan.
* GOGGLE — soft adjacency A (initialised in InitializeModel, projected
after each optimizer step via ProjectAdjacencyConstraints) is passed
through extraTensors. The fused optimizer allocates its moment buffer,
accumulates gradients, and applies the update in-place. Reparameterize
re-samples inside the forward closure so training stays stochastic;
ProjectAdjacencyConstraints runs after the fused step to keep the
adjacency on the valid soft-adjacency manifold.
* CLAP — the learned _logTemperature scalar (Radford 2021 / Wu 2023
contrastive-alignment temperature) goes through extraTensors. Both
audio and text encoders are in the layers list; the fused step handles
all three parameter classes uniformly.
Both fall through to the existing eager tape+optimizer path on any
failure (unsupported optimizer, non-compilable graph, etc).
Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(diffusion): batched per-element timesteps for DDPM-canonical training
Adds industry-standard batched-per-element timestep API to the diffusion stack
(Ho et al. 2020 §3, HuggingFace diffusers reference). Previously
DiffusionModelBase.Train sampled ONE timestep for the whole batch — reducing
the signal-to-noise diversity of the training gradient. Canonical DDPM training
samples a distinct timestep per batch element.
* INoiseScheduler.AddNoiseBatched(cleanBatch, noiseBatch, timesteps) — default
interface implementation delegates to the scalar AddNoise per element for
backward compatibility. Concrete schedulers can override with a fused
batched implementation.
* NoisePredictorBase.PredictNoiseBatched(noisyBatch, timesteps, conditioning) —
virtual with default slice-then-call-scalar implementation. Subclasses that
want a fused batched forward override this to keep the training loop on-device.
* DiffusionModelBase.PredictNoiseBatched — model-level counterpart with the
same default slice-then-call-scalar behavior.
* DiffusionModelBase.Train detects batched vs rank-1 input and routes through
the batched noise scheduler + batched predictor when input.Rank >= 2. Rank-1
unbatched inputs stay on the scalar path for backward compatibility.
This is the foundation for the industry-exceeding "batched-per-element +
fused-resident" diffusion training path — see follow-up commits that wire
DiffusionModelBase.Train through the fused compiled plan.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): wGAN-GP correctness fix + fused disc + DP-SGD wire-ups (4F/4G/4H)
Consumes Tensors PR ooples/AiDotNet.Tensors#763 (compiled backward with
createGraph=true, DP-SGD helper, multi-slot persistent inputs).
## 4G — WGAN-GP correctness fix + fused disc steps (5 files)
Root cause fixed for AiDotNet issue #1844: every ComputeGradientPenalty
implementation used the inner GradientTape's ComputeGradients WITHOUT
createGraph=true. The inner backward's ops didn't record on the outer
tape, so inputGradients had no GradFn chain back to the discriminator
weights. Effect: the gradient penalty was included in the loss VALUE
but NOT in the disc's gradient — WGAN-GP silently degraded to plain
WGAN with no 1-Lipschitz enforcement.
Fix (5 files: CTGAN, DPCTGAN, CopulaGAN, CausalGAN, TableGAN): add
createGraph: true to the inner ComputeGradients so the outer tape can
differentiate the penalty through the disc weights.
Also wired 4 disc steps through the fused compiled plan
(CausalGAN, CTGAN, CopulaGAN, TableGAN — DPCTGAN's disc is DP so goes
via 4H). Packs (real, fake) into one persistent input along axis 0;
loss closure splits scores back out and computes wasserstein + λ·GP.
The fused path activates once Tensors PR #763 lands (its 4C change
removes the !createGraph gate at GradientTape.cs:727); until then
these wire-ups fall through to the (now-corrected) eager tape path.
## 4H — DP-SGD wire-ups (2 files)
Local AiDotNet.Training.DpSgdStep<T> — drop-in mirror of the same
helper in Tensors PR #763 (Engines.Training.DpSgdStep<T>). Enables
the wire-ups to land in this PR without waiting on the Tensors NuGet
publish. Both implementations enforce the Abadi 2016 §3 Algorithm 1
clip-BEFORE-aggregate order via their structure.
* DPCTGAN.TrainDiscriminatorStepBatchedDP — routes the per-example
WGAN-GP + DP-SGD critic through DpSgdStep<T>. Objective: Wasserstein
+ λ·GP per example, clipped per-example, aggregated, noised, averaged.
* MedSynth.TrainDiscriminatorStepPerExampleDPSGD — routes the per-
example non-saturating BCE + DP-SGD critic through the same helper.
Once Tensors PR #763 merges + NuGet publishes, the local mirror can
be swapped for the Tensors version by changing the `using` — the API
surface is identical by design.
## 4F — Batched-per-element diffusion foundation
DiffusionModelBase.Train samples per-batch-element timesteps for
rank ≥ 2 inputs (Ho et al. 2020 canonical pattern; HuggingFace
diffusers reference), routing through NoiseSchedulerBase.AddNoiseBatched
+ DiffusionModelBase.PredictNoiseBatched. Rank-1 unbatched inputs
keep the scalar path for backward compat.
net471 doesn't support default interface implementations, so
AddNoiseBatched lives on NoiseSchedulerBase<T> (as virtual with a
default per-element delegate) rather than on the INoiseScheduler<T>
interface. DiffusionModelBase's fused-training wire-up (via Tensors
PR #763's PersistentInputRegistry) is queued for the NuGet-bump
follow-up commit — the API foundation is already in place.
Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(review): resolve 12 CodeRabbit findings on PR #1843
Addresses every unresolved review comment on the non-TS GPU-residency PR.
## Correctness fixes
* DiffusionModelBase.Train — RecomputeForward closure now dispatches
isBatched ? PredictNoiseBatched(inp, timesteps) : PredictNoise(inp, timestep),
so optimizer re-evaluation matches the recorded batched forward objective.
* NoisePredictorBase.PredictNoiseBatched — detect batch-aligned conditioning
(leading dim == batchSize) and slice per element; preserve shared conditioning
when the leading dim doesn't match. Fixes shape-mismatch / conditioning-shared
bugs in classifier-free-guidance-style predictors.
* CSDI.Train — remove the fused-plan branch. ComputeDenoisingPairTape samples
fresh (timestep, noise) each call, and calling it in both Fwd and Loss produces
independent samples that don't match. The compiled plan can't refresh the RNG
per replay either. Path stays on the eager tape until Tensors' PersistentInputRegistry
(PR ooples/AiDotNet.Tensors#763) lands.
* TFC.Train — ComputeContrastiveLossTape now runs INSIDE ForwardCombined so it
consumes the current-step persistent input (`inp`), not the outer `input` which
would freeze at compile time. Closure-captured local; Loss reads it with a
null-guard covering the Fwd-then-Loss ordering invariant.
* TOTEM.Train — capture the commitment tensor from ForwardNativeForTrainingWithCommitment's
first call; reuse it in Loss instead of running the quantizer a second time.
Without this, the compiled path performs an EMA SetCodebookValue update TWICE
per step and diverges from the eager path.
* NoiseSchedulerBase.AddNoiseBatched — validate full shape parity (rank + every
dim), not only the leading batch dim. Prevents indexing beyond noiseBatch's span
when a caller passes [B, smaller...] shapes.
## Correctness cleanup
* CTGAN.TrainGeneratorStepBatched — capture (act, condFromInput, maskFromInput)
from Fwd's single generator pass; reuse in Loss so the conditional-CE term
doesn't re-run GeneratorForwardWithResidualBatched + ApplyOutputActivationsBatched
(was doubling the per-step generator forward cost).
* TabSynGenerator.TrainVAEBatch — capture (mean, logVar) from Fwd's single encoder
pass; reuse in Loss so the encoder doesn't run twice per row. Also: if the fused
step fails mid-batch after fusedEngaged=true, drop to the eager path for the
remaining rows (no row is silently skipped).
* FourierNeuralOperator.TapeTrainStep — remove the duplicate _fourierLayers loop
in both the fused-path allTrainable collection AND the eager paramList. Fourier
layers are already registered into Layers at construction, so iterating them
again double-registered each Fourier parameter and drove the eager SGD to apply
the update twice per step.
## API cleanup
* GpuResidentFusedStep<T> — public → internal. Aligns with CompiledTapeTrainingStep<T>
which is already internal; keeps in-assembly training plumbing out of the public
API surface.
Also fixed an inadvertent null-forgiving operator (`!`) usage that slipped into
the review-fix edits. All new nullable annotations use explicit null-guards with
descriptive InvalidOperationException on invariant violation (per CLAUDE.md's
"never use null-forgiving operators" rule).
INoiseScheduler default-interface issue (net471 incompatibility) was already
fixed in an earlier commit (AddNoiseBatched moved to NoiseSchedulerBase).
Builds green net471 / net8.0 / net10.0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): vectorized fused DP-SGD/WGAN-GP/multi-slot primitives + consumer wire-ups
Adds three fused-plan training primitives (mirrors of AiDotNet.Tensors PR #763)
and wires the DP-SGD consumers through them:
* DpSgdFusedStep<T> — Abadi 2016 §3 Algorithm 1 per-example clip-before-aggregate.
Runs each per-example forward+backward through a compiled plan (LR=0 so weights
don't drift between replays), then computes the global L2 norm, clips, noises,
and aggregates via vectorized IEngine ops (TensorMultiply/ReduceSum for the
norm, TensorMultiplyScalar/TensorAdd for the accumulator, TensorRandomNormalInto
for on-device Gaussian noise). Returns aggregated gradients so the caller's
configured optimizer (Adam/AdamW/SGD/...) applies the update — no hardcoded
SGD step inside.
* WganGpFusedStep<T> — Gulrajani 2017 WGAN-GP critic step. Composes
E[D(fake)] − E[D(real)] + λ·(‖∇_x̃ D(x̃)‖₂ − 1)² inside one compiled plan with
the inner ∇_x̃ D(x̃) recorded via createGraph=true so it differentiates into
disc weights (issue #1844 fix). OnesLike uses vectorized Engine.TensorFill.
* MultiSlotFusedStep<T> — N-slot persistent input mechanism with plan cache
keyed by composite shape + parameter identity. Slots refreshed via
AsSpan().CopyTo(AsWritableSpan()) — no per-element loops on the hot path.
Consumer wire-ups (this PR):
* DPCTGANGenerator.TrainDiscriminatorStepBatchedDP — primary path routes through
DpSgdFusedStep.TryStep, falls back to the existing ComputePerExampleNoisedGradients
when the fused path can't engage (non-GPU host / compilation disabled).
* MedSynthGenerator.TrainDiscriminatorStepPerExampleDPSGD — same primary/fallback
layering.
* Both legacy fallback loops (ComputePerExampleNoisedGradients + MedSynth eager)
are now themselves vectorized: global-L2-norm via ReduceSum(g·g), clipped
accumulation via TensorMultiplyScalar+TensorAdd, on-device Gaussian noise via
TensorRandomNormalInto+TensorAdd — no scalar per-element loops anywhere on the
DP-SGD path.
Codebase convention adopted:
* Class-scope `private static IEngine Engine => AiDotNetEngine.Current;` and
`private static readonly INumericOperations<T> Ops = MathHelper.GetNumericOperations<T>();`
on each fused-step class (matches the ~20 activation/optimizer/etc. bases).
No IEngine or INumericOperations<T> threaded through method signatures.
Skipped (follow-ups filed):
* WGAN-GP consumer rewire → #1845 (blocked on IGradientBasedOptimizer<T> config
accessor extension; consumers already correct via GpuResidentFusedStep + local
createGraph=true ComputeGradientPenalty).
* Diffusion consumer rewire → #1846 (blocked on per-generator forward-refactor
to move _timestepProjection inside compiled plan while treating raw timestep
as a persistent slot).
Verification:
* net8.0 + net471 + net10.0 all build clean on both AiDotNet and AiDotNet.Tensors.
* Old DpSgdStep.cs deleted (replaced by DpSgdFusedStep).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(review): tFC + TOTEM preprocessing rewritten with traceable engine ops
Resolves the two BLOCKING CodeRabbit findings on PR #1843: both fused-plan
training paths were freezing preprocessing into the compiled plan because
their inner ops used host-side .Data.Span loops, so later replays reused the
first batch's normalized values / spectrum / argmin decisions instead of
recomputing per batch.
TFC — ApplyInstanceNormalization (RevIN) + ComputeFrequencyRepresentation:
* ApplyInstanceNormalization now delegates to a new stateless NormalizeWithStats
that returns (normalized, mean, std) as tensors. Under the hood: ReduceMean +
ReduceVariance + TensorSqrt + TensorBroadcastSubtract + TensorBroadcastDivide.
All ops record on the tape and re-execute per replay under the compiled plan.
* DenormalizeForecast likewise delegates to DenormalizeForecastWithStats, which
takes mean/std as explicit tensor parameters. ForwardNative threads them
through as locals so the compile-mode replay uses CURRENT-step stats instead
of frozen trace-time values.
* _revinMean/_revinStd (Vector<T> scalars) → _revinMeanTensor/_revinStdTensor
(Tensor<T>? nullable) — kept for the abstract override's external callers,
but the fused path never reads them.
* ComputeFrequencyRepresentation now uses Engine.RFFT for batched real FFT →
reshape to [B, halfN, 2] pairs → TensorMultiply + ReduceSum(axis=2) for
magSquared → TensorSqrt + TensorMultiplyScalar(1/n) for the one-sided
magnitude spectrum → TensorSlice + TensorFlip + TensorConcatenate to mirror
bins [1..n-halfN] into the tail. Handles even and odd n identically to the
old scalar impl.
* Fused-plan fast path in TFC.Train restored — now safe because both
preprocessing methods trace correctly.
TOTEM — VectorQuantize (VQ-VAE) traceable rewrite + post-Step EMA:
* New VectorQuantizeTraceable returns (quantized, commitmentLoss, argmin, head)
using Engine ops end-to-end: TensorBroadcastSubtract + TensorMultiply +
ReduceSum for distances, TensorArgMin along the codebookSize axis, per-c
TensorSliceAxis + TensorIndexSelectDiff + TensorStack for the gather,
Engine.StopGradient for the straight-through estimator, ReduceSum-based
commitment loss weighted by β/totalLen.
* EMA moved OUT of the compiled forward into a new UpdateCodebookEMA(head,
argmin). Called POST-Step by the fused path with the trace-time graph-node
references — their .Data reflects the LAST replay so the update lands
exactly once per batch (matches CodeRabbit's "EMA must execute exactly once
per batch" contract). Under the compiled plan, argmin/head are refreshed
by every _plan.Step() so post-Step reads see the current batch's values.
* UpdateCodebookEMA expresses the per-codebook scatter as: current codebook
slice + TensorScatterAdd((1-decay)·(head - gathered), argmin) → new slice,
then TensorConcatenate across codebook axis into the full [numCodebooks,
codebookSize, codebookDim] tensor, then Engine.TensorCopy back into the
_codebooks tensor object to preserve identity (future reads via the same
reference see the update).
* Legacy VectorQuantize is now a thin adapter around VectorQuantizeTraceable
for callers that don't need the extras.
* ForwardNativeForTrainingWithCommitment delegates to a new
ForwardNativeForTrainingWithVQExtras that exposes the argmin/head; the
original (forecast, commitmentLoss) contract is preserved for callers that
don't need EMA state.
* Fused-plan fast path in TOTEM.Train restored — now safe because VQ is
fully traceable AND the EMA runs exactly once per batch in post-Step eager
code.
No new Tensors primitives were needed — the engine already has RFFT,
ReduceMean/Variance, TensorSqrt, TensorBroadcastSubtract/Divide, TensorFlip,
TensorConcatenate, TensorArgMin, TensorIndexSelectDiff, TensorSliceAxis,
TensorStack, StopGradient, TensorScatterAdd, and TensorCopy, all in the
autodiff/compile registry per OpRegistry.cs.
Verification:
* net8.0 + net471 + net10.0 all build clean.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): centralize WGAN-GP + diffusion consumers through fused primitives (#1847)
Closes #1845 and #1846. Routes all four WGAN-GP critics through WganGpFusedStep
(the fused-plan primitive from PR #1843) and adds MultiSlotFusedStep wire-ups
to the three tabular diffusion consumers plus a base-class opt-in hook for
DiffusionModelBase subclasses.
## Optimizer config plumbing
Zero new API surface: IFusedOptimizerSpec.TryGetFusedOptimizerConfig already
exposes (OptimizerType, LR, Beta1, Beta2, Epsilon, WeightDecay, Schedule,
UseBf16Moments). Widened NeuralNetworkBase<T>.TryMapToFusedOptimizerConfig
from private to internal so the sibling generators in the same assembly can
reuse the existing helper.
## WGAN-GP consumers (#1845)
* CTGANGenerator, CopulaGANGenerator, TableGANGenerator, CausalGANGenerator —
each critic training method now attempts WganGpFusedStep.TryStep FIRST with
the discriminator's optimizer hyperparameters extracted via
TryMapToFusedOptimizerConfig, falls back to the existing
GpuResidentFusedStep path (secondary fused), then the eager tape (final
fallback). The ε ∈ [0, 1]^B epsilon sampler uses
Engine.TensorRandomUniformRange to match each critic's local
ComputeGradientPenalty behavior.
* Non-Adam optimizers (Lion, LBFGS) that don't implement IFusedOptimizerSpec
cleanly fall through — TryMapToFusedOptimizerConfig returns false and the
code path skips to GpuResidentFusedStep as before.
## Diffusion consumers (#1846)
* TabDDPMGenerator — refactored to expose a slot-based forward
(BuildTabDDPMSlots + DenoiserForwardFromTensors +
ComputeDiffusionLossTapeFromTensors). Per-row TrainBatch loop now attempts
MultiSlotFusedStep with (numNoisy, actualNoise, catNoisy, catClean,
rawSinusoidalTimeEmbed) as persistent slots. The learnable
_timestepProjection stays INSIDE the compiled forward closure so its
weights participate in the backward pass. Plan is compiled once on the
first row and replayed via slot-data refresh for subsequent rows.
* TabSynGenerator — TrainDiffusionBatch's per-row loop wired with
MultiSlotFusedStep on (noisyLatent, actualNoise, projectedTimeEmbed).
Matches the existing eager path's semantic that _timestepProjection is
NOT in _diffMLPLayers (kept detached in the eager path too), so the
projected embedding is precomputed host-side per row and passed as slot
data.
* Finance/Forecasting/Foundation/CSDI —
- ApplyInstanceNormalization rewritten with traceable engine ops
(ReduceMean + ReduceVariance + TensorSqrt + broadcast subtract/divide) —
same pattern as the TFC RevIN fix. The previous `.Data.Span` per-batch
loop froze at trace time.
- New BuildCsdiSlots + DenoiserForwardFromSlots express the DDPM x_t
formation and packed denoising input via TensorConcatenate + engine
scalar multiplies. Replaces the `.Data.Span[i] = xt[0, i]` fill that
baked the trace batch's x_t into the compiled plan.
- Train() attempts MultiSlotFusedStep first, falls back to the existing
eager ComputeDenoisingPairTape path when the fused path can't engage.
* Diffusion/DiffusionModelBase —
- New opt-in `protected virtual bool SupportsFusedDenoising => false;`
property. Base default is false so no existing subclass changes
behavior.
- Train() attempts MultiSlotFusedStep when SupportsFusedDenoising is true
AND the training optimizer maps cleanly to a fused config. Slots:
(noisySample, noise). Loss = MSE(pred, noise). QAT shadow restoration
is preserved on the fused-success path.
- Subclasses with fully-traceable PredictNoise / PredictNoiseBatched
(e.g. after auditing to remove `.Data.Span` host loops) can opt in via
a single-line override; no infrastructure changes needed elsewhere.
## Verification
* net8.0, net471, net10.0 all build clean.
* No API surface changes on IGradientBasedOptimizer<T> — the existing
IFusedOptimizerSpec interface (already implemented by all fuse-able
optimizers) provided everything needed.
* All consumers preserve eager fallback path for non-fuse-able optimizers
and non-GPU hosts.
Co-authored-by: franklinic <franklin@ivorycloud.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
* feat(training): wire additional WGAN-GP + diffusion consumers through fused primitives (#1848)
Extends PR #1847 with three additional consumer wire-ups discovered during a
comprehensive audit against the primitives added in PR #1843. Each consumer
attempts the fused path first via the existing IFusedOptimizerSpec /
TryMapToFusedOptimizerConfig plumbing and falls back to eager tape training
when the fused path can't engage.
## WGAN-GP consumers (additional beyond #1845)
* NeuralNetworks/WGANGP.cs — standalone WGAN-GP class. Previously used the
legacy flat-vector round-trip (three Critic.Predict calls per step,
GetParameterGradients + host-side vector combine + UpdateCriticWithOptimizer).
TrainCriticBatchWithGP now attempts WganGpFusedStep.TryStep first, using
Critic.Layers as the parameter source and a per-batch ε ~ U(0, 1) sampler
matching each critic's local ComputeGradientPenalty behavior. Falls back to
the legacy path when the critic's optimizer has no fused-kernel mapping.
## Diffusion consumers (additional beyond #1846)
* NeuralNetworks/SyntheticData/FinDiffGenerator.cs — per-row DDPM training
(Sattarov et al. 2023). TrainBatch caches a MultiSlotFusedStep across rows
so the compiled plan is built once and replayed via slot-data refresh for
subsequent rows. Slots: (packedDenoiserInput, targetNoise). Falls back to
the existing Train(input, targetNoise) call on miss.
* NeuralNetworks/SyntheticData/AutoDiffTabGenerator.cs — per-row DDPM training
with a custom TapeStepOver optimizer step. Same MultiSlotFusedStep caching
pattern as FinDiff. Slots: (denoiserInput, targetNoise). Falls back to the
existing tape-based TapeStepOver path on miss.
## Explicitly not wired in this PR (documented)
* NeuralNetworks/GenerativeAdversarialNetwork.cs — uses BCE loss with optional
GP regularization (a separate auxiliary optimizer step), NOT Wasserstein +
GP. Wiring WganGpFusedStep would change training semantics from BCE to
Wasserstein. Requires a separate design decision.
* Finance/Forecasting/Foundation/{CCDM,MGTSD,TSDiff,TimeDiff,TimeGrad}.cs and
Finance/Probabilistic/DiffusionTS.cs — each uses .Data.Span host-side packs
for the denoising input (same trace-freeze issue TFC/CSDI hit in PR #1843).
Each needs a TFC/CSDI-scale traceable rewrite BEFORE fused wiring is safe.
Deferred to individual per-consumer PRs.
* MetaLearning/Algorithms/{MetaDDPMAlgorithm,MetaDMAlgorithm,MetaDiffAlgorithm}.cs
— hand-rolled Vector<T> params with index arithmetic, NOT the
ILayer/Engine/tape infrastructure. Would need full rewrite to fit MultiSlotFusedStep.
* DiffusionModelBase subclasses (DDPMModel, DiffWaveModel, LatentDiffusionModelBase)
— the SupportsFusedDenoising opt-in hook (added in PR #1847) is available,
but flipping it safely requires per-class audit of PredictNoise → UNet
traceability. Left as follow-up work; the mechanism is in place.
## Verification
* net8.0, net471, net10.0 all build clean.
* No API surface changes.
Co-authored-by: franklinic <franklin@ivorycloud.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
* chore(deps): bump AiDotNet.Tensors 0.111.2 -> 0.113.0 (activates #763 for fused paths)
0.113.0 publishes Tensors PR #763 — this branch's gating dependency. #763's key fix
(4C): the compiled/persistent backward now honors createGraph=true (GradientTape.
ComputeGradients previously gated the compiled path on !createGraph), so the WGAN-GP
gradient penalty's inner backward differentiates into the disc weights through the
fused compiled plan instead of silently returning zeros (issue #1844). Against 0.111.2
the fused GPU-resident WGAN-GP path would have silently degraded to plain WGAN.
The src/Training fused-primitive mirrors (WganGpFusedStep, MultiSlotFusedStep,
DpSgdFusedStep) stay as the consumer-side primitives that #1847/#1848 centralize every
consumer through; they call the public engine API, so the bump alone routes them onto
#763's fixed compiled backward. Also picks up #765 (compiled ReduceMax axis fill) and
#764 (resident-param fused-Adam fix). Native OneDNN/OpenBLAS/CLBlast bumped in lockstep
(all published). Builds green on net8.0.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: franklinic <franklin@ivorycloud.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>1 parent e790723 commit a5e69ca
35 files changed
Lines changed: 3784 additions & 402 deletions
File tree
- src
- Audio/Fingerprinting
- Diffusion
- NoisePredictors
- Schedulers
- Finance/Forecasting
- Foundation
- Neural
- NeuralNetworks
- SyntheticData
- Tasks/Graph
- PhysicsInformed/NeuralOperators
- Training
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
243 | 256 | | |
244 | 257 | | |
245 | 258 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
501 | 501 | | |
502 | 502 | | |
503 | 503 | | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
504 | 550 | | |
505 | 551 | | |
506 | 552 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
129 | 152 | | |
130 | 153 | | |
131 | 154 | | |
| |||
802 | 825 | | |
803 | 826 | | |
804 | 827 | | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
805 | 863 | | |
806 | 864 | | |
807 | 865 | | |
| |||
1034 | 1092 | | |
1035 | 1093 | | |
1036 | 1094 | | |
1037 | | - | |
1038 | | - | |
1039 | | - | |
1040 | | - | |
1041 | | - | |
1042 | | - | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
| 1214 | + | |
| 1215 | + | |
| 1216 | + | |
| 1217 | + | |
| 1218 | + | |
| 1219 | + | |
| 1220 | + | |
1043 | 1221 | | |
1044 | 1222 | | |
1045 | 1223 | | |
1046 | 1224 | | |
1047 | 1225 | | |
1048 | | - | |
1049 | | - | |
| 1226 | + | |
| 1227 | + | |
| 1228 | + | |
| 1229 | + | |
| 1230 | + | |
| 1231 | + | |
1050 | 1232 | | |
1051 | 1233 | | |
1052 | 1234 | | |
| |||
1150 | 1332 | | |
1151 | 1333 | | |
1152 | 1334 | | |
1153 | | - | |
| 1335 | + | |
| 1336 | + | |
| 1337 | + | |
| 1338 | + | |
1154 | 1339 | | |
1155 | 1340 | | |
1156 | 1341 | | |
| |||
0 commit comments