chore(lint): remove dead biome suppression in tar-xz node-api spec#119
Merged
Conversation
The for-await drain loop body has a '/* drain */' comment that satisfies biome's noEmptyBlockStatements check, so the suppression above never fired. Drop the dead biome-ignore line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/tar-xz/test/node-api.spec.ts:249had// biome-ignore lint/suspicious/noEmptyBlockStatements: intentional drainabove afor awaitloop whose body contains/* drain */(a comment, not an empty block). The suppression never fired because biome treats the commented body as non-empty — the linter flagged it assuppressions/unused.Drop the line, no behavior change.
Diff
1 file, -1 line.
Gates
pnpm --filter tar-xz build: EXIT 0pnpm exec biome check .: EXIT 0 (1 warning remaining: pre-existing CC=17 onparseMemlimitSize, tracked separately)pnpm test: 707 pass / 0 fail / 3 skippedTest plan