Skip to content

test(tar-xz): close extract.ts coverage partials with v8 ignores #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oorabona merged 1 commit into from
Apr 30, 2026
Merged

test(tar-xz): close extract.ts coverage partials with v8 ignores #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/tar-xz/src/node/extract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ async function drainEntryChunks(
): Promise<void> {
while (true) {
const result = await parser.next();
/* v8 ignore start: parseTar always emits 'end' before returning; this done:true branch is unreachable via the public API */
if (result.done) return;
/* v8 ignore stop */
if (result.value.kind !== 'chunk') {
lookaheadRef.value = result.value;
return;
Expand Down Expand Up @@ -193,6 +195,7 @@ function createEntryDataPull(
): () => AsyncGenerator<Uint8Array> {
let dataGenInFlight = false;
return function makeDataGen(): AsyncGenerator<Uint8Array> {
/* v8 ignore start: internal state machine invariant — makeTarEntryWithData() calls dataPull() exactly once per entry and never exposes makeDataGen to consumers; concurrent-iteration path is unreachable via public API */
if (dataGenInFlight) {
// D-5 invariant violation: triggered if the same entry's data generator
// is created twice (`makeDataGen()` called more than once for one
Expand All @@ -202,7 +205,6 @@ function createEntryDataPull(
// `code: 'TAR_PARSER_INVARIANT'` attribute matches the convention used
// by other invariant errors in this module (e.g. stray-chunk in extract,
// size-mismatch in bytes()) and keeps downstream filters consistent.
/* v8 ignore start: internal state machine invariant — makeTarEntryWithData() calls dataPull() exactly once per entry and never exposes makeDataGen to consumers; concurrent-iteration path is unreachable via public API */
const err = new Error('concurrent entry.data iteration is not supported') as Error & {
code?: string;
};
Expand All @@ -215,7 +217,9 @@ function createEntryDataPull(
try {
while (true) {
const r = await parser.next();
/* v8 ignore start: parseTar always emits 'end' before returning; this done:true branch is unreachable via the public API */
if (r.done) return;
/* v8 ignore stop */
if (r.value.kind === 'chunk') {
yield r.value.data;
} else {
Expand Down Expand Up @@ -290,13 +294,15 @@ export async function* extract(
try {
while (true) {
const result = await nextParseEvent(parser, lookaheadRef);
/* v8 ignore start: parseTar always emits 'end' before returning; this done:true branch is unreachable via the public API */
if (result.done) break;
/* v8 ignore stop */
const ev = result.value;

if (ev.kind === 'end') break;
/* v8 ignore start: state machine invariant — parseTar never emits 'chunk' before 'entry'; this branch guards against a hypothetical parser bug that cannot be triggered via the public API */
if (ev.kind === 'chunk') {
// Stray chunk at outer-loop level is a parser invariant violation (D-5).
/* v8 ignore start: state machine invariant — parseTar never emits 'chunk' before 'entry'; this branch guards against a hypothetical parser bug that cannot be triggered via the public API */
const err = new Error('parser invariant: chunk emitted before entry');
(err as Error & { code: string }).code = 'TAR_PARSER_INVARIANT';
throw err;
Expand Down
Loading