-
Notifications
You must be signed in to change notification settings - Fork 4
fix(stream): drop @ts-expect-error via intersection-cast (forward-compat with @types/node 25.7.0) #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix(stream): drop @ts-expect-error via intersection-cast (forward-compat with @types/node 25.7.0) #155
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
50eea34
fix(stream): tolerate @types/node Transformer.cancel availability
oorabona 90302bc
fix(stream): apply @ts-expect-error → @ts-ignore swap (forgotten in p…
oorabona 561d03d
fix(stream): shield @ts-ignore directives from biome noTsIgnore auto-…
oorabona 8541d1d
fix(stream): drop @ts-expect-error in favor of intersection-cast (for…
oorabona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { readFileSync } from 'node:fs'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| /** | ||
| * Forward-compat guard for `src/wasm/stream.ts`. | ||
| * | ||
| * `@types/node` adds and (more rarely) removes typed members of the Streams | ||
| * interfaces across minor bumps. The file deliberately uses an intersection | ||
| * cast on `TransformStream` constructor calls so it needs ZERO TypeScript | ||
| * suppression directives. Any directive — in either the expect-error or | ||
| * ignore form — would either mask a real upstream regression, or fire | ||
| * TS2578 ("unused directive") the moment the typing it suppresses lands | ||
| * upstream, breaking the daily Refresh Lockfile workflow. | ||
| * | ||
| * This test is the deterministic regression detector for that invariant. | ||
| */ | ||
| describe('src/wasm/stream.ts — TS directive hygiene', () => { | ||
| it('contains no @ts-ignore or @ts-expect-error directive', () => { | ||
| const path = fileURLToPath(new URL('../../src/wasm/stream.ts', import.meta.url)); | ||
| const source = readFileSync(path, 'utf8'); | ||
|
|
||
| // Match the directive form specifically (with leading `//` and a word boundary | ||
| // after the directive name), so the rule name appearing inside a doc-comment | ||
| // or string literal does not produce a false positive. | ||
| const directivePattern = /\/\/\s*@ts-(expect-error|ignore)\b/; | ||
| expect(source).not.toMatch(directivePattern); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.