chore: add initial CI workflow#473
Conversation
staceybeard
left a comment
staceybeard
left a comment
There was a problem hiding this comment.
Looks good. Is this a draft, or ready to go?
| markdownlint: | ||
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
Is markdownlint separate from lint for a functional reason? Or just by preference?
There was a problem hiding this comment.
It is separate to make it reusable since we use it in several projects. It's because we use a separate formatter when running in CI.
It's work in progress. I can't mark it as a draft. I added you too soon :) |
| # actionlint has a shellcheck integration which extracts shell scripts in `run:` steps from GitHub Actions | ||
| # and checks these with shellcheck. This is arguably its most useful feature, | ||
| # but the integration only works if shellcheck is installed | ||
| - "github.com/wasilibs/go-shellcheck/cmd/shellcheck@v0.10.0" |
There was a problem hiding this comment.
Is there a reason you used go-shellcheck instead of https://github.com/koalaman/shellcheck?
There was a problem hiding this comment.
source: https://github.com/astral-sh/ruff/blob/main/.pre-commit-config.yaml#L122
I remember seeing a discussion about this which I can't find right now. I believe the reason was that it will work on any platform this way...
3 participants
No description provided.