Refactor API response to use top-level 'data' attribute for consistency#524
Refactor API response to use top-level 'data' attribute for consistency#524Alsrory wants to merge 5 commits into
Conversation
|
Thanks for the feedback @arukompas, I'm on it.
في الخميس، ١١ يونيو ٢٠٢٦، ٠٩:٣١ Arunas Skirius ***@***.***>
كتب:
… ***@***.**** requested changes on this pull request.
1. Missing test coverage for the change
2. UI needs to be backwards compatible, as publishing updated UI
assets is optional.
3. Formatting is out of place
—
Reply to this email directly, view it on GitHub
<#524?email_source=notifications&email_token=ANL2QMMF6IREMDI55YKAFX347JG4XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBXGQZDONZZHEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4474277993>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANL2QMKSQEO6VQBH5V7V63L47JG4XAVCNFSNUABFKJSXA33TNF2G64TZHM2TENBYHA3DSNJVHNEXG43VMU5TINRSGU4TCNRYGIYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ANL2QMNGH3ZCRLTIHJL4KGT47JG4XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBXGQZDONZZHEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/ANL2QMI5ZHRZPIQFAI2TJ7D47JG4XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBXGQZDONZZHEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi @arukompas, I have updated the PR to address the consistency of the API response structure while maintaining full backward compatibility by keeping the original keys. I have manually verified the changes by running the full test suite locally, and all 329 tests are passing successfully. Also, I have resolved the merge conflicts to ensure the branch is up-to-date with the latest main. Looking forward to your review! |
|
Hi @arukompas, I have updated the PR to resolve all merge conflicts and synced it with the latest main. I have also verified everything locally, and all tests are passing. Regarding the workflow status: I have enabled the actions in my fork, but it seems they are still awaiting approval on the main repository side. Could you please approve the workflow run so we can verify the changes against the CI/CD pipeline? I am ready to make any further adjustments if needed. Thank you! |
This PR refactors the API response structure to use a top-level data attribute for the folders list.
Reason: This ensures consistency with standard API patterns and provides a clean namespace for future metadata (e.g., meta, links) without causing breaking changes or frontend parsing issues.
Changes: Updated FoldersController to wrap the resource collection, and adjusted the frontend axios response handler to parse data.data.
I have verified the changes locally, and the data is correctly received and parsed by the frontend.