Update nginx conf template#1636
Conversation
…ry, prompt and keycloak routes Signed-off-by: Gurunath S <gurunath.s@intel.com>
… into opea-issue-fix
sgurunat
requested review from
XinyaoWa,
letonghan and
lvliang-intel
as code owners
|
Hi @sgurunat |
… into opea-issue-fix
Signed-off-by: Ubuntu <ubuntu@ip-172-31-1-234.us-west-2.compute.internal>
Signed-off-by: Gurunath S <gurunath.s@intel.com>
|
Hi @sgurunat only left one CI of ChatQnA seems failed on dataprep-redis-server health check |
|
@sgurunat |
There was a problem hiding this comment.
When using NGINX for forwarding, the BACKEND_SERVICE_NAME, BACKEND_SERVICE_IP, and BACKEND_SERVICE_PORT in the template correspond to the back_end of each example. These values are dynamically assigned through docker_compose.yaml, so there's no need to set the variables separately for each example. For details, refer to: https://github.com/opea-project/GenAIExamples/blob/main/ChatQnA/docker_compose/intel/hpu/gaudi/compose.yaml#L175.
There was a problem hiding this comment.
@WenjiaoYue - This is needed for ProductivitySuite. Because in ProductivitySuite all the solutions will be in one single thing. If we use common variables it will not work.
There was a problem hiding this comment.
@sgurunat Got it. Initially, we assumed your PR was to fix pr_503. If it's specifically for ProductivitySuite, we recommend creating a separate nginx.conf rather than modifying the Nginx template, which is intended for general use across all examples.
-
Since your nginx.conf is specific to this example, we suggest placing it under ProductivitySuite/docker_image_build.
-
I also noticed there's already a PR related to Nginx changes in GenAIExamples, but it seems to be missing the Nginx image build step. You can refer to this line in ChatQnA as a reference, and make sure the Dockerfile points to the nginx.conf you placed in ProductivitySuite/docker_image_build.
|
This issue is: nginx port should not be 80, it should be configurable. nginx template is a template. You can create different instances based on this template. But not to add every instance into the template. It's just a template in GenAI components, cannot be changed. |
Signed-off-by: Gurunath S <gurunath.s@intel.com>
for more information, see https://pre-commit.ci
….yaml file Signed-off-by: Gurunath S <gurunath.s@intel.com>
… into opea-issue-fix
Signed-off-by: Gurunath S <gurunath.s@intel.com>
| COPY comps/third_parties/nginx/deployment/docker_compose/start-nginx-productivitysuite.sh /usr/local/bin/start-nginx.sh | ||
| RUN chmod +x /usr/local/bin/start-nginx.sh | ||
|
|
||
| CMD ["/usr/local/bin/start-nginx.sh"] |
There was a problem hiding this comment.
There is CI failure.
Does this pass your local test?
FYR,
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
6 participants
Description
This change is basically on nginx.conf.template and other files inside nginx folder in regarding to the issue mentioned below on non root user and parameterization of nginx port.
Have added routes for codegen, docsum, chathistory, prompt and keycloak in nginx and used this nginx server in GenAIExamples for Codegen, Docsum and ProductivitySuite.
Issues
This change is related to issue tickets mentioned below.
opea-project/GenAIExamples#517
opea-project/GenAIExamples#503
Type of change
List the type of change like below. Please delete options that are not relevant.
Tests
Tested the changes with ProductivitySuite and it works fine