Updated SearchQnA to use nginx like ChatQnA#1769
Conversation
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
for more information, see https://pre-commit.ci
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
for more information, see https://pre-commit.ci
…in the build like ChatQnA Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
…inx port 80 Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SearchQnA Xeon example to use an nginx component similar to ChatQnA. Key changes include updating the UI configuration for the new port, adding nginx services to various docker compose files for Intel and AMD platforms, and revising the README documentation to reflect these changes.
Reviewed Changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SearchQnA/ui/svelte/playwright.config.ts | Updated baseURL from port 5173 to 80 for nginx use. |
| SearchQnA/docker_image_build/build.yaml | Added nginx build configuration. |
| SearchQnA/docker_compose/intel/hpu/gaudi/compose.yaml | Added new nginx service for Intel HPU. |
| SearchQnA/docker_compose/intel/cpu/xeon/compose.yaml | Added new nginx service for Intel Xeon. |
| SearchQnA/docker_compose/intel/cpu/xeon/README.md | Updated build step to include nginx image build. |
| SearchQnA/docker_compose/amd/gpu/rocm/compose_vllm.yaml | Added new nginx service for AMD ROCm with vLLM. |
| SearchQnA/docker_compose/amd/gpu/rocm/compose.yaml | Added new nginx service for AMD ROCm. |
| SearchQnA/README.md | Revised the architecture diagram and steps. |
Files not reviewed (5)
- SearchQnA/tests/test_compose_on_gaudi.sh: Language not supported
- SearchQnA/tests/test_compose_on_rocm.sh: Language not supported
- SearchQnA/tests/test_compose_on_xeon.sh: Language not supported
- SearchQnA/tests/test_compose_vllm_on_rocm.sh: Language not supported
- SearchQnA/ui/svelte/.env: Language not supported
Comments suppressed due to low confidence (1)
SearchQnA/docker_compose/amd/gpu/rocm/compose.yaml:175
- [nitpick] The nginx service name here is inconsistent with the naming used in the Intel compose files (e.g., 'searchqna-xeon-nginx-server' and 'searchqna-gaudi-nginx-server'). Consider standardizing the service name to include a 'searchqna' prefix for clarity and consistency.
search-nginx-server:
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
Hi @lvliang-intel and @Spycsh, any other feedback on this PR? This adds nginx to SearchQnA, and updates the unit tests. |
yinghu5
left a comment
There was a problem hiding this comment.
Good Updates. Just check if is there purpose to move up the Readme.md from SearchQnA/docker_compose/intel/cpu/xeon/README.md
to SearchQnA/docker_compose/intel/cpu/README.md
It may not align with other samples. and later the CI build doc failed.
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
…linking to the folder. Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
You're right, thank you @lvliang-intel for the catch. I've instead updated the diagram to include Nginx in the SearchQnA/README.md
|
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> Signed-off-by: alexsin368 <alex.sin@intel.com>
Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Description
Updated SearchQnA Xeon to be like ChatQnA that uses nginx component.
Key changes:
BACKEND_BASE_URLsince nginx will proxypass.Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
The SearchQnA Xeon example now uses nginx component from GenAIComps.
Tests
Kept the same tests. Also manually tested UI on cloud machine.