Skip to content

fix bugs in DocIndexRetriever #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chensuyue merged 11 commits into from
Apr 10, 2025
Merged

fix bugs in DocIndexRetriever #1770

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
95a44b0
fix bugs
minmin-intel Apr 7, 2025
b888b59
lengthen startup wait time on gaudi
minmin-intel Apr 7, 2025
9346c8c
Merge branch 'main' into docindexretriever-fix-v1.3
lvliang-intel Apr 9, 2025
20919a0
Merge branch 'main' into docindexretriever-fix-v1.3
rbrugaro Apr 9, 2025
5ebbd0a
Merge branch 'main' into docindexretriever-fix-v1.3
chensuyue Apr 9, 2025
feb81e3
add depends_on condition
minmin-intel Apr 9, 2025
76773e1
Merge branch 'main' into docindexretriever-fix-v1.3
minmin-intel Apr 9, 2025
c91e6d8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 9, 2025
c6a4346
align inputs and outputs
minmin-intel Apr 9, 2025
c6dec9a
fix errors
minmin-intel Apr 10, 2025
b49169c
Merge branch 'docindexretriever-fix-v1.3' of https://github.com/minmi…
minmin-intel Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions DocIndexRetriever/docker_compose/intel/cpu/xeon/compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ services:
dataprep-redis-service:
image: ${REGISTRY:-opea}/dataprep:${TAG:-latest}
container_name: dataprep-redis-server
# volumes:
# - $WORKDIR/GenAIExamples/DocIndexRetriever/docker_image_build/GenAIComps/comps:/home/user/comps
depends_on:
- redis-vector-db
Comment thread
chensuyue marked this conversation as resolved.
Outdated
ports:
Expand All @@ -28,7 +26,7 @@ services:
REDIS_URL: ${REDIS_URL}
REDIS_HOST: ${REDIS_HOST}
INDEX_NAME: ${INDEX_NAME}
TEI_ENDPOINT: ${TEI_EMBEDDING_ENDPOINT}
TEI_EMBEDDING_ENDPOINT: ${TEI_EMBEDDING_ENDPOINT}
HUGGINGFACEHUB_API_TOKEN: ${HUGGINGFACEHUB_API_TOKEN}
LOGFLAG: ${LOGFLAG}
tei-embedding-service:
Expand All @@ -54,8 +52,6 @@ services:
embedding:
image: ${REGISTRY:-opea}/embedding:${TAG:-latest}
container_name: embedding-server
# volumes:
# - $WORKDIR/GenAIExamples/DocIndexRetriever/docker_image_build/GenAIComps/comps:/home/comps
ports:
- "6000:6000"
ipc: host
Expand Down Expand Up @@ -114,8 +110,6 @@ services:
reranking:
image: ${REGISTRY:-opea}/reranking:${TAG:-latest}
container_name: reranking-tei-xeon-server
# volumes:
# - $WORKDIR/GenAIExamples/DocIndexRetriever/docker_image_build/GenAIComps/comps:/home/user/comps
depends_on:
tei-reranking-service:
condition: service_healthy
Expand Down
4 changes: 3 additions & 1 deletion DocIndexRetriever/docker_compose/intel/hpu/gaudi/compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ services:
https_proxy: ${https_proxy}
Comment thread
chensuyue marked this conversation as resolved.
REDIS_URL: ${REDIS_URL}
INDEX_NAME: ${INDEX_NAME}
TEI_ENDPOINT: ${TEI_EMBEDDING_ENDPOINT}
TEI_EMBEDDING_ENDPOINT: ${TEI_EMBEDDING_ENDPOINT}
HUGGINGFACEHUB_API_TOKEN: ${HUGGINGFACEHUB_API_TOKEN}
tei-embedding-service:
image: ghcr.io/huggingface/tei-gaudi:1.5.0
Expand Down Expand Up @@ -87,6 +87,8 @@ services:
INDEX_NAME: ${INDEX_NAME}
LOGFLAG: ${LOGFLAG}
RETRIEVER_COMPONENT_NAME: "OPEA_RETRIEVER_REDIS"
TEI_EMBEDDING_ENDPOINT: ${TEI_EMBEDDING_ENDPOINT}
HUGGINGFACEHUB_API_TOKEN: ${HUGGINGFACEHUB_API_TOKEN}
restart: unless-stopped
tei-reranking-service:
image: ghcr.io/huggingface/text-embeddings-inference:cpu-1.6
Expand Down
2 changes: 1 addition & 1 deletion DocIndexRetriever/tests/test_compose_on_gaudi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function start_services() {

# Start Docker Containers
docker compose up -d
sleep 30
sleep 5m
Comment thread
chensuyue marked this conversation as resolved.
Outdated
echo "Docker services started!"
}

Expand Down