Skip to content

Enable health check for dataprep in ChatQnA#1799

Merged
chensuyue merged 11 commits into
opea-project:mainfrom
letonghan:refine_dataprep_healthcheck
Apr 17, 2025
Merged

Enable health check for dataprep in ChatQnA#1799
chensuyue merged 11 commits into
opea-project:mainfrom
letonghan:refine_dataprep_healthcheck

Conversation

@letonghan
Copy link
Copy Markdown
Collaborator

Description

Enable health check for dataprep in ChatQnA

Issues

Fixes #1699

Type of change

  • New feature (non-breaking change which adds new functionality)

Dependencies

None

Tests

Local tested

Signed-off-by: letonghan <letong.han@intel.com>
Copilot AI review requested due to automatic review settings April 11, 2025 09:03
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 11, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

ChatQnA/docker_compose/intel/gaudi/compose_faqgen_tgi.yaml:118

  • Review the updated healthcheck endpoint to verify that port 80 is correct for this service; if the service actually listens on a different port or uses environment-provided configuration, update the healthcheck command accordingly.
test: ["CMD-SHELL", "curl -f http://localhost:80/health || exit 1"]

ChatQnA/docker_compose/intel/gaudi/compose_faqgen.yaml:109

  • Ensure the change to use 'localhost:80' aligns with the service's actual listening port; if the expected port differs, adjust the healthcheck command accordingly.
test: ["CMD-SHELL", "curl -f http://localhost:80/health || exit 1"]

ChatQnA/docker_compose/intel/cpu/xeon/compose.yaml:111

  • Verify that the healthcheck endpoint port (80) is correct for this service; if the service documentation indicates a different port, update the command to match.
test: ["CMD-SHELL", "curl -f http://localhost:80/health || exit 1"]

Comment thread ChatQnA/docker_compose/intel/cpu/xeon/compose_milvus.yaml
letonghan and others added 4 commits April 14, 2025 10:02
@letonghan
Copy link
Copy Markdown
Collaborator Author

@chensuyue These failed CI tested are all cancelled and cannot fixed by rerun, could you please help to check?

@chensuyue
Copy link
Copy Markdown
Collaborator

chensuyue commented Apr 14, 2025

@chensuyue These failed CI tested are all cancelled and cannot fixed by rerun, could you please help to check?

It's now fixed.

@joshuayao joshuayao added this to OPEA Apr 16, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 16, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 16, 2025
@yinghu5 yinghu5 self-requested a review April 16, 2025 02:08
@joshuayao joshuayao added bug Something isn't working v1.3 labels Apr 16, 2025
@yinghu5
Copy link
Copy Markdown
Collaborator

yinghu5 commented Apr 16, 2025

Hi @letonghan some CIs failed, please take care

@letonghan
Copy link
Copy Markdown
Collaborator Author

The failed CI tests on rocm might be related to this issue: #1812

@yinghu5 yinghu5 requested a review from chensuyue April 17, 2025 01:23
@chensuyue chensuyue merged commit ae31e4f into opea-project:main Apr 17, 2025
62 of 76 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in OPEA Apr 17, 2025
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
letonghan pushed a commit that referenced this pull request Sep 17, 2025
Signed-off-by: Yi Yao <yi.a.yao@intel.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v1.3

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]Data-prep failed on ingesting files

6 participants