Conversation
Signed-off-by: chensuyue <suyue.chen@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
.github/workflows/_run-docker-compose.yml:67
- The use of a wildcard match ("gaudi"*) is more flexible, but please verify that it does not unintentionally match hardware names beyond the intended ones (e.g. strings like "gaudi-test").
if [[ "${{ inputs.hardware }}" == "gaudi"* ]]; then
.github/workflows/_build_image.yml:46
- The revised condition now explicitly resets should_skip to false for nodes matching 'gaudi' or 'xeon'. Please ensure that this logic correctly differentiates hardware nodes as intended and does not override necessary skip behavior for other valid inputs.
if [[ "${{ inputs.node }}" == "gaudi" || "${{ inputs.node }}" == "xeon" ]]; then
.github/workflows/_build_comps_base_image.yml:39
- Similar to the previous workflow, verify that resetting the skip flag for nodes matching 'gaudi' or 'xeon' aligns with the intended hardware support logic and does not inadvertently bypass necessary job skipping.
if [[ "${{ inputs.node }}" == "gaudi" || "${{ inputs.node }}" == "xeon" ]]; then
ZePan110
approved these changes
Apr 15, 2025
lvliang-intel
approved these changes
Apr 15, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: chensuyue <suyue.chen@intel.com>
yongfengdu
pushed a commit
to yongfengdu/GenAIExamples
that referenced
this pull request
May 8, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
May 16, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com> Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
letonghan
added a commit
that referenced
this pull request
Sep 17, 2025
* support mongo for storage Signed-off-by: letonghan <letong.han@intel.com> * revert unrelated changes Signed-off-by: letonghan <letong.han@intel.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add dependency motor Signed-off-by: letonghan <letong.han@intel.com> * fix import path Signed-off-by: letonghan <letong.han@intel.com> * change DocList to List, for current version of docarray Signed-off-by: letonghan <letong.han@intel.com> --------- Signed-off-by: letonghan <letong.han@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable more flexible support for test HWs, including gaudi(2), xeon(spr), rocm, arc, gaudi3, and xeon-gnr.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
https://github.com/opea-project/GenAIExamples/actions/runs/14463967068
Retest after fix: https://github.com/opea-project/GenAIExamples/actions/runs/14570137323
Retest on ROCm after remove local comps-base image: https://github.com/opea-project/GenAIExamples/actions/runs/14570883332