Conversation
Signed-off-by: chensuyue <suyue.chen@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new workflow input parameter "opea_branch" for CD test purposes. Key changes include:
- Adding a new input parameter "opea_branch" in the _run-docker-compose.yml workflow.
- Propagating the "opea_branch" input into the Docker compose jobs.
- Integrating "opea_branch" into the _example-workflow.yml for consistency with the CD test setup.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/_run-docker-compose.yml | Added a new optional input "opea_branch" with a default value and integrated it into the job environment. |
| .github/workflows/_example-workflow.yml | Included the "opea_branch" input in the job configuration. |
Comments suppressed due to low confidence (2)
.github/workflows/_run-docker-compose.yml:35
- [nitpick] The variable name 'opea_branch' may be ambiguous; consider renaming it to something more descriptive or adding a comment to clarify its intended purpose.
opea_branch:
.github/workflows/_example-workflow.yml:79
- [nitpick] The use of 'opea_branch' may be unclear; consider using a more descriptive name or providing inline documentation for better clarity.
opea_branch: ${{ inputs.opea_branch }}
ZePan110
approved these changes
Apr 23, 2025
yinghu5
approved these changes
Apr 24, 2025
chensuyue
added a commit
that referenced
this pull request
Apr 25, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com> (cherry picked from commit f7002fc)
yongfengdu
pushed a commit
to yongfengdu/GenAIExamples
that referenced
this pull request
May 8, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
May 16, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com> Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set opea_branch for CD test
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.