Skip to content

Integrate CodeGen set_env to ut scripts.#1871

Closed
ZePan110 wants to merge 9 commits into
mainfrom
enhance
Closed

Integrate CodeGen set_env to ut scripts.#1871
ZePan110 wants to merge 9 commits into
mainfrom
enhance

Conversation

@ZePan110

@ZePan110 ZePan110 commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Description

  1. Integrate CodeGen set_env to ut scripts.
  2. Add README.md for CodeGen UT scripts.
  3. Optimization test check.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Add README.md for CodeGen UT scripts.
Optimization test check.

Signed-off-by: ZePan110 <ze.pan@intel.com>
Copilot AI review requested due to automatic review settings April 23, 2025 07:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates CodeGen’s set_env into the test scripts and adds documentation for running tests across different hardware environments. Key changes include the addition of a new README to guide test setup and execution, plus optimization of test checks.

Files not reviewed (6)
  • CodeGen/docker_compose/amd/gpu/rocm/set_env.sh: Language not supported
  • CodeGen/docker_compose/amd/gpu/rocm/set_env_vllm.sh: Language not supported
  • CodeGen/tests/test_compose_on_gaudi.sh: Language not supported
  • CodeGen/tests/test_compose_on_rocm.sh: Language not supported
  • CodeGen/tests/test_compose_on_xeon.sh: Language not supported
  • CodeGen/tests/test_compose_vllm_on_rocm.sh: Language not supported
Comments suppressed due to low confidence (1)

CodeGen/tests/README.md:1

  • [nitpick] The header specifies 'E2E test scripts' while the PR title mentions UT scripts; consider aligning the terminology to avoid confusion.
# CodeGen E2E test scripts

@github-actions

github-actions Bot commented Apr 23, 2025

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Signed-off-by: ZePan110 <ze.pan@intel.com>
Add README.md for CodeGen UT scripts.
Optimization test check.

Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>

@yinghu5 yinghu5 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

yinghu5 and others added 3 commits April 24, 2025 16:34
… into enhance

Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
@ZePan110 ZePan110 added the WIP label Apr 28, 2025
@ZePan110 ZePan110 closed this Apr 30, 2025
@ZePan110 ZePan110 reopened this May 7, 2025
ZePan110 and others added 2 commits May 7, 2025 16:51
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: Yao, Qing <qing.yao@intel.com>
@ZePan110 ZePan110 closed this May 20, 2025
@ZePan110 ZePan110 deleted the enhance branch June 26, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants