Skip to content

Fix security issues for helm test workflow#1908

Merged
ZePan110 merged 2 commits into
mainfrom
fix-sec
May 6, 2025
Merged

Fix security issues for helm test workflow#1908
ZePan110 merged 2 commits into
mainfrom
fix-sec

Conversation

@ZePan110
Copy link
Copy Markdown
Collaborator

@ZePan110 ZePan110 commented May 6, 2025 •
edited by chensuyue
Loading

Description

Fix security issues for helm test workflow

Issues

https://github.com/opea-project/GenAIExamples/security/code-scanning/31

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

https://github.com/opea-project/GenAIExamples/actions/runs/14853044830/job/41700159514

@ZePan110
Fix 1
97b5398 
Signed-off-by: ZePan110 <ze.pan@intel.com>
Copilot AI review requested due to automatic review settings May 6, 2025 05:46
@ZePan110 ZePan110 requested a review from chensuyue as a code owner May 6, 2025 05:46
Copilot AI reviewed May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix security issues by refining the permissions granted to the Helm Chart E2e Test workflow.

  • Updated the permissions from a broad "read-all" to a more specific "contents: read" to improve security.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@ZePan110 ZePan110 changed the title Fix security issues Fix security issues for helm test workflow May 6, 2025
@ZePan110 ZePan110 merged commit 5375332 into main May 6, 2025
24 checks passed
@ZePan110 ZePan110 deleted the fix-sec branch May 6, 2025 07:54
yongfengdu pushed a commit to yongfengdu/GenAIExamples that referenced this pull request May 8, 2025
@ZePan110 @pre-commit-ci @yongfengdu
Fix security issues for helm test workflow (opea-project#1908)
8c1e342 
Signed-off-by: ZePan110 <ze.pan@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
letonghan pushed a commit that referenced this pull request Sep 17, 2025
@WenjiaoYue
Fix GenAIComps handle_message to include full chat history (#1908)
a5b2fb9 
* Fix GenAIComps handle_message to include full chat history

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>

* Updated expected output in test_handle_message_with_content_list.

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>

---------

Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
@ZePan110 @pre-commit-ci @cogniware-devops
Fix security issues for helm test workflow (opea-project#1908)
61778fb 
Signed-off-by: ZePan110 <ze.pan@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chensuyue chensuyue chensuyue approved these changes

@lvliang-intel lvliang-intel lvliang-intel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZePan110 @chensuyue @lvliang-intel