Organize set_env.sh paths and update README.md#1920
Conversation
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the paths used to set up the environment across several README files, ensuring consistency with changes in the repository structure.
- Updated relative paths in Translation, DocSum, and CodeTrans service README files
- Adjusted cd commands and source paths to reflect the new directory organization
Reviewed Changes
Copilot reviewed 6 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Translation/docker_compose/intel/hpu/gaudi/README.md | Adjusted cd commands to navigate from a deeper directory to hpu/gaudi/ |
| Translation/docker_compose/intel/cpu/xeon/README.md | Updated relative paths in cd commands for a more concise directory change |
| DocSum/docker_compose/intel/hpu/gaudi/README.md | Modified initial navigation to GenAIExamples directory and added cd hpu/gaudi/ |
| DocSum/docker_compose/intel/cpu/xeon/README.md | Simplified cd commands by adjusting the relative path from GenAIExamples |
| CodeTrans/docker_compose/intel/hpu/gaudi/README.md | Changed the path used for sourcing the set_env.sh script |
| CodeTrans/docker_compose/intel/cpu/xeon/README.md | Updated the source path for set_env.sh to reflect the new directory layout |
Files not reviewed (13)
- CodeTrans/docker_compose/intel/set_env.sh: Language not supported
- CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_on_xeon.sh: Language not supported
- CodeTrans/tests/test_compose_tgi_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_tgi_on_xeon.sh: Language not supported
- DocSum/docker_compose/intel/set_env.sh: Language not supported
- DocSum/tests/test_compose_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_on_xeon.sh: Language not supported
- DocSum/tests/test_compose_tgi_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_tgi_on_xeon.sh: Language not supported
- Translation/docker_compose/intel/set_env.sh: Language not supported
- Translation/tests/test_compose_on_gaudi.sh: Language not supported
- Translation/tests/test_compose_on_xeon.sh: Language not supported
Comments suppressed due to low confidence (6)
Translation/docker_compose/intel/hpu/gaudi/README.md:45
- Verify that the updated relative path accurately navigates to the intended directory given the repository reorganization, and that the subsequent 'cd hpu/gaudi/' command properly reaches the target folder.
cd ../../
Translation/docker_compose/intel/cpu/xeon/README.md:45
- Confirm that the revised cd command correctly adjusts the working directory and that the following 'cd cpu/xeon' command aligns with the new directory structure.
cd ../../
DocSum/docker_compose/intel/hpu/gaudi/README.md:32
- Ensure that splitting the navigation into two steps ('cd GenAIExamples/DocSum/docker_compose/intel/' and then 'cd hpu/gaudi/') results in the correct working directory for deployment.
cd GenAIExamples/DocSum/docker_compose/intel/
DocSum/docker_compose/intel/cpu/xeon/README.md:30
- Double-check that the modified navigation commands properly update the working directory when followed by the 'cd cpu/xeon/' command for correct deployment.
cd GenAIExamples/DocSum/docker_compose/intel/
CodeTrans/docker_compose/intel/hpu/gaudi/README.md:49
- Ensure that the new source path correctly locates the set_env.sh script in light of the reorganized directory structure.
source docker_compose/intel/set_env.sh
CodeTrans/docker_compose/intel/cpu/xeon/README.md:49
- Confirm that updating the source command to use 'docker_compose/intel/set_env.sh' properly reflects the new file layout and functions as expected.
source docker_compose/intel/set_env.sh
Signed-off-by: ZePan110 <ze.pan@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR organizes the set_env.sh paths and updates the README.md instructions across various services. The changes ensure that relative paths correctly reflect the new directory structure and update the workflow for enhanced error messaging.
- Updated relative paths in Translation, DocSum, and CodeTrans README files to align with repository structure.
- Revised the workflow script to include a delay and improved error messages for path validation.
Reviewed Changes
Copilot reviewed 8 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Translation/docker_compose/intel/hpu/gaudi/README.md | Updated relative cd commands for HPU service instructions. |
| Translation/docker_compose/intel/cpu/xeon/README.md | Updated relative cd commands for CPU service instructions. |
| DocSum/docker_compose/intel/hpu/gaudi/README.md | Adjusted cd commands to reflect repository structure for HPU. |
| DocSum/docker_compose/intel/cpu/xeon/README.md | Adjusted cd commands to reflect repository structure for CPU. |
| CodeTrans/docker_compose/intel/hpu/gaudi/README.md | Updated source path for set_env.sh to new location. |
| CodeTrans/docker_compose/intel/cpu/xeon/README.md | Updated source path for set_env.sh to new location. |
| .github/workflows/pr-link-path-scan.yml | Added a delay variable and refined error messages in the path scan job. |
Files not reviewed (12)
- CodeTrans/docker_compose/intel/set_env.sh: Language not supported
- CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_on_xeon.sh: Language not supported
- CodeTrans/tests/test_compose_tgi_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_tgi_on_xeon.sh: Language not supported
- DocSum/tests/test_compose_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_on_xeon.sh: Language not supported
- DocSum/tests/test_compose_tgi_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_tgi_on_xeon.sh: Language not supported
- Translation/docker_compose/intel/set_env.sh: Language not supported
- Translation/tests/test_compose_on_gaudi.sh: Language not supported
- Translation/tests/test_compose_on_xeon.sh: Language not supported
|
reproduce on local test. DocSum depends Langchang, the langchain version changed. langchain-core 0.3.55 => 0.3.59 |
|
#1917 Update DocSum README and environment configuration fix partial of docsum issues. |
Signed-off-by: ZePan110 <ze.pan@intel.com>
|
DocSum is known issue, so merge this PR first. |
Signed-off-by: ZePan110 <ze.pan@intel.com> Co-authored-by: chen, suyue <suyue.chen@intel.com> Co-authored-by: Ying Hu <ying.hu@intel.com> Signed-off-by: alexsin368 <alex.sin@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com> Co-authored-by: chen, suyue <suyue.chen@intel.com> Co-authored-by: Ying Hu <ying.hu@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Description
Organize set_env.sh paths and update README.md
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.