Skip to content

Organize set_env.sh paths and update README.md#1920

Merged
ZePan110 merged 10 commits into
mainfrom
org-setemv
May 20, 2025
Merged

Organize set_env.sh paths and update README.md#1920
ZePan110 merged 10 commits into
mainfrom
org-setemv

Conversation

@ZePan110

@ZePan110 ZePan110 commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Description

Organize set_env.sh paths and update README.md

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

ZePan110 added 2 commits May 8, 2025 16:07
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Copilot AI review requested due to automatic review settings May 8, 2025 08:31
@github-actions

github-actions Bot commented May 8, 2025

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the paths used to set up the environment across several README files, ensuring consistency with changes in the repository structure.

  • Updated relative paths in Translation, DocSum, and CodeTrans service README files
  • Adjusted cd commands and source paths to reflect the new directory organization

Reviewed Changes

Copilot reviewed 6 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Translation/docker_compose/intel/hpu/gaudi/README.md Adjusted cd commands to navigate from a deeper directory to hpu/gaudi/
Translation/docker_compose/intel/cpu/xeon/README.md Updated relative paths in cd commands for a more concise directory change
DocSum/docker_compose/intel/hpu/gaudi/README.md Modified initial navigation to GenAIExamples directory and added cd hpu/gaudi/
DocSum/docker_compose/intel/cpu/xeon/README.md Simplified cd commands by adjusting the relative path from GenAIExamples
CodeTrans/docker_compose/intel/hpu/gaudi/README.md Changed the path used for sourcing the set_env.sh script
CodeTrans/docker_compose/intel/cpu/xeon/README.md Updated the source path for set_env.sh to reflect the new directory layout
Files not reviewed (13)
  • CodeTrans/docker_compose/intel/set_env.sh: Language not supported
  • CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
  • CodeTrans/tests/test_compose_on_xeon.sh: Language not supported
  • CodeTrans/tests/test_compose_tgi_on_gaudi.sh: Language not supported
  • CodeTrans/tests/test_compose_tgi_on_xeon.sh: Language not supported
  • DocSum/docker_compose/intel/set_env.sh: Language not supported
  • DocSum/tests/test_compose_on_gaudi.sh: Language not supported
  • DocSum/tests/test_compose_on_xeon.sh: Language not supported
  • DocSum/tests/test_compose_tgi_on_gaudi.sh: Language not supported
  • DocSum/tests/test_compose_tgi_on_xeon.sh: Language not supported
  • Translation/docker_compose/intel/set_env.sh: Language not supported
  • Translation/tests/test_compose_on_gaudi.sh: Language not supported
  • Translation/tests/test_compose_on_xeon.sh: Language not supported
Comments suppressed due to low confidence (6)

Translation/docker_compose/intel/hpu/gaudi/README.md:45

  • Verify that the updated relative path accurately navigates to the intended directory given the repository reorganization, and that the subsequent 'cd hpu/gaudi/' command properly reaches the target folder.
cd ../../

Translation/docker_compose/intel/cpu/xeon/README.md:45

  • Confirm that the revised cd command correctly adjusts the working directory and that the following 'cd cpu/xeon' command aligns with the new directory structure.
cd ../../

DocSum/docker_compose/intel/hpu/gaudi/README.md:32

  • Ensure that splitting the navigation into two steps ('cd GenAIExamples/DocSum/docker_compose/intel/' and then 'cd hpu/gaudi/') results in the correct working directory for deployment.
cd GenAIExamples/DocSum/docker_compose/intel/

DocSum/docker_compose/intel/cpu/xeon/README.md:30

  • Double-check that the modified navigation commands properly update the working directory when followed by the 'cd cpu/xeon/' command for correct deployment.
cd GenAIExamples/DocSum/docker_compose/intel/

CodeTrans/docker_compose/intel/hpu/gaudi/README.md:49

  • Ensure that the new source path correctly locates the set_env.sh script in light of the reorganized directory structure.
source docker_compose/intel/set_env.sh

CodeTrans/docker_compose/intel/cpu/xeon/README.md:49

  • Confirm that updating the source command to use 'docker_compose/intel/set_env.sh' properly reflects the new file layout and functions as expected.
source docker_compose/intel/set_env.sh

@ZePan110 ZePan110 changed the title Organize set_env.sh paths and update README.sh Organize set_env.sh paths and update README.md May 8, 2025
@ZePan110 ZePan110 requested a review from chensuyue as a code owner May 8, 2025 09:01
Signed-off-by: ZePan110 <ze.pan@intel.com>
ZePan110 added 2 commits May 9, 2025 10:02
Signed-off-by: ZePan110 <ze.pan@intel.com>
@ZePan110

Copy link
Copy Markdown
Collaborator Author

#1936

@yinghu5 yinghu5 requested review from Copilot and yinghu5 May 14, 2025 07:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR organizes the set_env.sh paths and updates the README.md instructions across various services. The changes ensure that relative paths correctly reflect the new directory structure and update the workflow for enhanced error messaging.

  • Updated relative paths in Translation, DocSum, and CodeTrans README files to align with repository structure.
  • Revised the workflow script to include a delay and improved error messages for path validation.

Reviewed Changes

Copilot reviewed 8 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Translation/docker_compose/intel/hpu/gaudi/README.md Updated relative cd commands for HPU service instructions.
Translation/docker_compose/intel/cpu/xeon/README.md Updated relative cd commands for CPU service instructions.
DocSum/docker_compose/intel/hpu/gaudi/README.md Adjusted cd commands to reflect repository structure for HPU.
DocSum/docker_compose/intel/cpu/xeon/README.md Adjusted cd commands to reflect repository structure for CPU.
CodeTrans/docker_compose/intel/hpu/gaudi/README.md Updated source path for set_env.sh to new location.
CodeTrans/docker_compose/intel/cpu/xeon/README.md Updated source path for set_env.sh to new location.
.github/workflows/pr-link-path-scan.yml Added a delay variable and refined error messages in the path scan job.
Files not reviewed (12)
  • CodeTrans/docker_compose/intel/set_env.sh: Language not supported
  • CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
  • CodeTrans/tests/test_compose_on_xeon.sh: Language not supported
  • CodeTrans/tests/test_compose_tgi_on_gaudi.sh: Language not supported
  • CodeTrans/tests/test_compose_tgi_on_xeon.sh: Language not supported
  • DocSum/tests/test_compose_on_gaudi.sh: Language not supported
  • DocSum/tests/test_compose_on_xeon.sh: Language not supported
  • DocSum/tests/test_compose_tgi_on_gaudi.sh: Language not supported
  • DocSum/tests/test_compose_tgi_on_xeon.sh: Language not supported
  • Translation/docker_compose/intel/set_env.sh: Language not supported
  • Translation/tests/test_compose_on_gaudi.sh: Language not supported
  • Translation/tests/test_compose_on_xeon.sh: Language not supported

Comment thread Translation/docker_compose/intel/hpu/gaudi/README.md
Comment thread CodeTrans/docker_compose/intel/hpu/gaudi/README.md
Comment thread .github/workflows/pr-link-path-scan.yml
@xiguiw

xiguiw commented May 15, 2025

Copy link
Copy Markdown
Collaborator

reproduce on local test.
hang on data process, timeout.

DocSum depends Langchang, the langchain version changed.
With previous version 0.3.55 and 0.3.14, the DocSum passed locally, hang on 0.3.59/0.3.16 locally.

langchain-core 0.3.55 => 0.3.59
langchain-openai 0.3.14 => 0.3.16

langchain                                0.3.14
langchain-community             0.3.14
langchain-core                        0.3.59
langchain-huggingface           0.1.2
langchain-openai                    0.3.16
langchain-text-splitters           0.3.8
langchainhub                          0.1.21
langserve                                 0.3.1
langsmith                                0.2.11


langchain                                0.3.14
langchain-community             0.3.14
langchain-core                        0.3.55
langchain-huggingface           0.1.2
langchain-openai                    0.3.14
langchain-text-splitters           0.3.8
langchainhub                          0.1.21
langserve                                0.3.1
langsmith                                0.2.11

@xiguiw xiguiw mentioned this pull request May 15, 2025
10 tasks
@yinghu5

yinghu5 commented May 16, 2025

Copy link
Copy Markdown
Collaborator

#1917 Update DocSum README and environment configuration fix partial of docsum issues.

@chensuyue

Copy link
Copy Markdown
Collaborator

DocSum is known issue, so merge this PR first.

@ZePan110 ZePan110 merged commit 8a9f3f4 into main May 20, 2025
68 of 83 checks passed
@ZePan110 ZePan110 deleted the org-setemv branch May 20, 2025 02:05
alexsin368 pushed a commit to alexsin368/GenAIExamples that referenced this pull request Aug 13, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
Co-authored-by: Ying Hu <ying.hu@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
Co-authored-by: Ying Hu <ying.hu@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants