Conversation
Signed-off-by: ZePan110 <ze.pan@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the input validation for the helm test workflow by updating the regex pattern used in the validation.
- Updated regex to allow alphanumeric characters (both uppercase and lowercase) instead of just alphabetic characters.
- The error message, however, still suggests that only lowercase alphanumeric characters are allowed.
Comments suppressed due to low confidence (1)
.github/workflows/_helm-e2e.yml:140
- The regex pattern now allows uppercase characters, but the error message states that only lowercase alphanumeric characters are allowed. Consider updating the error message or modifying the regex to only allow lowercase characters to maintain consistency.
if [[ ! "$example" =~ ^[a-zA-Z0-9]{1,20}$ ]] || [[ "$example" =~ \\.\." ]] || [[ "$example" == -* || "$example" == *- ]]; then
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
chensuyue
approved these changes
May 12, 2025
letonghan
approved these changes
May 12, 2025
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix input check for helm test workflow
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
https://github.com/opea-project/GenAIExamples/actions/runs/14966494611 test passed