[DocSum] Fixed docsum deployment issues.#1942
Closed
Zhenzhong1 wants to merge 2 commits into
Closed
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Zhenzhong1
requested review from
Spycsh,
WenjiaoYue and
lvliang-intel
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the deployed version references in multiple README files from v1.2 to v1.3 to address deployment issues and adds missing vLLM parameter setup and proxy error instructions.
- Updated checkout commands across docker compose files to use the latest version (v1.3)
- Added an environment variable setup instruction in one DocSum README file
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Translation/docker_compose/intel/hpu/gaudi/README.md | Updated checkout command to v1.3 |
| Translation/docker_compose/intel/cpu/xeon/README.md | Updated checkout command to v1.3 |
| Translation/docker_compose/amd/gpu/rocm/README.md | Updated checkout command to v1.3 |
| SearchQnA/docker_compose/intel/hpu/gaudi/README.md | Updated checkout command to v1.3 |
| SearchQnA/docker_compose/intel/cpu/xeon/README.md | Updated checkout command to v1.3 |
| SearchQnA/docker_compose/amd/gpu/rocm/README.md | Updated checkout command to v1.3 |
| DocSum/docker_compose/intel/hpu/gaudi/README.md | Updated checkout command to v1.3 and added HUGGINGFACE_API_TOKEN environment variable instructions |
| DocSum/docker_compose/intel/cpu/xeon/README.md | Updated checkout command to v1.3 |
| CodeTrans/docker_compose/amd/gpu/rocm/README.md | Updated checkout command to v1.3 |
| ChatQnA/docker_compose/intel/hpu/gaudi/README.md | Updated checkout command to v1.3 |
| ChatQnA/docker_compose/intel/cpu/xeon/README.md | Updated checkout command to v1.3 |
| AudioQnA/docker_compose/intel/hpu/gaudi/README.md | Updated checkout command to v1.3 |
| AudioQnA/docker_compose/intel/cpu/xeon/README_vllm.md | Updated checkout command to v1.3 (note the duplicated cd command) |
| AudioQnA/docker_compose/intel/cpu/xeon/README.md | Updated checkout command to v1.3 |
Files not reviewed (1)
- DocSum/docker_compose/set_env.sh: Language not supported
eero-t
approved these changes
May 13, 2025
eero-t
left a comment
eero-t
left a comment
Contributor
There was a problem hiding this comment.
Approved, looks OK to me.
Contributor
|
Note that this will conflict with earlier PR #1917 => discuss to avoid overlap? |
4 tasks
Zhenzhong1
force-pushed
the
zhenzhong/docsumValidate
branch
from
46a769e to
caa3f3c
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[DocSum] Fixed docsum deployment issues.
Issues
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests