Skip to content

Fix CD test get FaqGen values_files error#2305

Closed
ZePan110 wants to merge 2 commits into
mainfrom
ze-fix/CD
Closed

Fix CD test get FaqGen values_files error#2305
ZePan110 wants to merge 2 commits into
mainfrom
ze-fix/CD

Conversation

@ZePan110
Copy link
Copy Markdown
Collaborator

@ZePan110 ZePan110 commented Oct 13, 2025

Description

Fix CD test get FaqGen values_files error

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

https://github.com/opea-project/GenAIExamples/actions/runs/18482299201

Signed-off-by: ZePan110 <ze.pan@intel.com>
Copilot AI review requested due to automatic review settings October 13, 2025 06:09
@ZePan110 ZePan110 requested a review from chensuyue as a code owner October 13, 2025 06:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 13, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with retrieving values_files for the FaqGen example during CD testing in the Helm e2e workflow. The change adds a special case to handle FaqGen by looking for faqgen-specific YAML files in the ChatQnA directory instead of the standard FaqGen directory.

  • Adds conditional logic to handle FaqGen example differently in CD mode
  • Uses ChatQnA directory path with faqgen filter for FaqGen values files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/_helm-e2e.yml
Signed-off-by: ZePan110 <ze.pan@intel.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ZePan110 ZePan110 closed this Oct 14, 2025
@ZePan110 ZePan110 deleted the ze-fix/CD branch October 29, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants