update README & code enhancement#2366
Merged
Merged
Conversation
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements UI bug fixes, code enhancements, and documentation improvements, focusing on improving the pipeline and agent management features. The key changes include:
- Enhanced embedding model inference type support (vLLM/local) with UI controls
- Improved agent management with detail view capabilities and pipeline filtering
- Updated API endpoints to use ID-based references instead of name-based
- Added collapsible sidebar functionality in chatbot interface
- General code cleanup and documentation updates
Reviewed changes
Copilot reviewed 40 out of 66 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| EdgeCraftRAG/ui/vue/src/views/settings/index.vue | Added tabbed interface for pipeline and agent settings |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/type.ts | Changed model_url to api_base for consistency |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/index.vue | Updated to use ID-based API calls instead of name-based |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/enum.ts | Added description fields to generator types |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/Indexer.vue | Added vLLM inference type support for embeddings with model URL validation |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/Generator.vue | Added generator type descriptions and improved model handling |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/EditDialog.vue | Changed to use pipeline ID instead of name for updates |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/Table.vue | Updated to use ID-based operations and removed store dependency |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/DetailDrawer.vue | Added inference type display support |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Agent/index.vue | Added detail drawer for viewing agent information |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Agent/components/UpdateDialog.vue | Added pipeline filtering for FreeChat type and warning message |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Agent/components/Table.vue | Enhanced table with view functionality and type display |
| EdgeCraftRAG/ui/vue/src/views/chatbot/index.vue | Implemented collapsible sidebar functionality |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/index.vue | Added collapsed state support with tooltips |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/Chatbot/ChatHistory.vue | Added collapsed state with icon-only view |
| EdgeCraftRAG/ui/vue/src/api/pipeline/index.ts | Changed API functions to use ID-based endpoints |
| EdgeCraftRAG/edgecraftrag/server.py | Fixed error handling in lifespan function |
| EdgeCraftRAG/edgecraftrag/requirements.txt | Downgraded langchain-core version |
| EdgeCraftRAG/edgecraftrag/components/model.py | Fixed OpenAI embedding model initialization |
| EdgeCraftRAG/edgecraftrag/components/agents/utils.py | Removed domain-specific terminology from LLM evaluation |
| EdgeCraftRAG/edgecraftrag/api_schema.py | Added inference_type field to IndexerIn |
| EdgeCraftRAG/edgecraftrag/api/v1/pipeline.py | Added inference type handling for embedding models |
| EdgeCraftRAG/edgecraftrag/api/v1/model.py | Added vLLM embedding model endpoint |
| EdgeCraftRAG/edgecraftrag/api/v1/knowledge_base.py | Added null check for active pipeline |
| EdgeCraftRAG/edgecraftrag/VERSION | Updated version to 26.01-Dev |
| EdgeCraftRAG/docs/Agentic_RAG_Guide_Zh.md | Added Chinese agent guide documentation |
| EdgeCraftRAG/docs/Agentic_RAG_Guide.md | Added English agent guide documentation |
| EdgeCraftRAG/docs/Advanced_Setup.md | Added multi-GPU deployment instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
for more information, see https://pre-commit.ci
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
Yongbozzz
requested review from
chensuyue,
ftian1,
lkk12014402,
minmin-intel and
rbrugaro
as code owners
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
lvliang-intel
approved these changes
Dec 19, 2025
Yongbozzz
force-pushed
the
1217_dev
branch
2 times, most recently
from
38be86b to
a278bbf
Compare
for more information, see https://pre-commit.ci
ZePan110
approved these changes
Dec 22, 2025
ZePan110
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a