Skip to content

Fix CogniwareIms pri-commit issues#2400

Merged
ZePan110 merged 2 commits into
mainfrom
ze/fix
Jan 21, 2026
Merged

Fix CogniwareIms pri-commit issues#2400
ZePan110 merged 2 commits into
mainfrom
ze/fix

Conversation

@ZePan110
Copy link
Copy Markdown
Collaborator

@ZePan110 ZePan110 commented Jan 21, 2026

Description

Fix CogniwareIms pri-commit issues

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Copilot AI review requested due to automatic review settings January 21, 2026 07:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 21, 2026

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses pre-commit issues in the CogniwareIms project by adding missing imports and refactoring a health check function.

Changes:

  • Added missing json import to the dbqna_service module
  • Added missing HTTPException import to the opea_client module
  • Refactored health check logic by extracting service check functionality into a private method

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
CogniwareIms/backend/app/services/opea_client.py Added HTTPException import and extracted _check_service method to fix undefined reference
CogniwareIms/backend/app/services/dbqna_service.py Added json import to resolve missing dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CogniwareIms/backend/app/services/opea_client.py
Comment thread CogniwareIms/backend/app/services/dbqna_service.py
@ZePan110 ZePan110 requested a review from joshuayao January 21, 2026 07:22
@ZePan110 ZePan110 merged commit aa1d1a8 into main Jan 21, 2026
17 checks passed
@ZePan110 ZePan110 deleted the ze/fix branch January 21, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants