Switch to JuliaFormatter V2#1032
Draft
arlowhite wants to merge 2 commits into
Draft
Conversation
arlowhite
force-pushed
the
fix/formatter
branch
from
ffe904f to
f6d3ed1
Compare
Contributor
Author
2 tasks
arlowhite
commented
Feb 3, 2026
Contributor
Author
arlowhite
left a comment
arlowhite
left a comment
There was a problem hiding this comment.
highlighting interesting changes
| import GeoMakie.GeoJSON.FeatureCollection as FC | ||
|
|
||
| import ADRIA.FileIO, ADRIA.GFT | ||
| using ADRIA.FileIO: FileIO |
Contributor
Author
There was a problem hiding this comment.
do you like this style better? there may be a formatting option, haven't checked
|
|
||
| sel_asv_scens = dropdims( | ||
| mean(asv_scens(; timesteps=timespan)[scenarios=show_idx]; dims=:timesteps); | ||
| mean( |
Contributor
Author
There was a problem hiding this comment.
different line breaks
| varying_cols = [ | ||
| i for (i, col) in enumerate(eachcol(scens)) | ||
| if !all(==(first(col)), col) | ||
| if !all(==(first(col)), col) |
Contributor
Author
There was a problem hiding this comment.
changed indent, is this more correct or would you want the indent here?
| factors=At(target_factors) | ||
| ] | ||
| factors = At(target_factors) | ||
| ] |
| # Alias default constructor | ||
| FogPreferences(names, criteria, directions) = | ||
| DecisionPreferences(names, criteria, directions) | ||
| FogPreferences(names, criteria, directions) = DecisionPreferences( |
Contributor
Author
There was a problem hiding this comment.
better or worse? this one feels more like personal preference
| [filter(x -> occursin(yr, x), joinpath.(file_path, conn_fns)) for yr in years] | ||
| ) | ||
| [filter(x -> occursin(yr, x), joinpath.(file_path, conn_fns)) for yr in years] | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
another v2 indent fix
| # reduction is to capped to 0. | ||
| @. capped_dhw = | ||
| min.(ℯ^(0.17 + 0.35 * max(0.0, dhw' - (a_adapt + (tstep * n_adapt)))) - 1.0, 100.0) | ||
| @. capped_dhw = min.( |
Contributor
Author
There was a problem hiding this comment.
similar to above, no newline after =
| @test all( | ||
| diff[summary=At(:lower_bound)] .<= diff[summary=At(:agg_value)] .<= | ||
| diff[summary=At(:upper_bound)] | ||
| diff[summary = At(:lower_bound)] .<= |
|
|
||
| viz.map( | ||
| TEST_RS, guided_diff[summary=At(:agg_value)]; diverging=true, fig_opts=fig_opts | ||
| TEST_RS, guided_diff[summary = At(:agg_value)]; diverging=true, |
Contributor
Author
There was a problem hiding this comment.
I think the spacing around = just made line too long
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #1029
I'm not sure what changed recently, JuliaFormatter 2 was released Oct 2024
https://github.com/domluna/JuliaFormatter.jl/releases/tag/v2.0.0
format(".")returned
falsefirst time, ran 2nd, then returnedtrue