Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 55 55
Lines 2516 2516
Branches 142 142
=======================================
Hits 2280 2280
Misses 163 163
Partials 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| [submodule "."] | ||
| branch = pypartmc | ||
| [submodule "nanobind_json"] | ||
| branch = pypartmc |
There was a problem hiding this comment.
Shouldn't nanobind_json submodule stay at pypartmc branch?
There was a problem hiding this comment.
if so, let's introduce a test that fails otherwise!
There was a problem hiding this comment.
PyPartMC/tests/test_aero_mode.py
Line 317 in d1c9eb4
This test should fail due to circular reference - it fails on my machine. Looking at the main branch of
nanobind_json, it shouldn't be even able to compile due to compatibility errors with current nanobind. But it seems that everything worked on CI (could it somehow pulled the "old" submodules?).
Regardless, soon enough we should be able to use the main branch of nanobind_json ;)
There was a problem hiding this comment.
IIUC, the branch option is only used for submodule updates, while even without specifying it the commit hash registered during last commit points to the specific version of the submodule
There was a problem hiding this comment.
No description provided.