Skip to content

other isotopes in isotope methods; cache D_ratio and alpha in bolin_number; add diffusivity ratios using Grahams law for other isotopes; tests for Bolin number#1834

Merged
AgnieszkaZaba merged 73 commits into
open-atmos:mainfrom
AgnieszkaZaba:bo-with-simulation
Jun 22, 2026
Merged

Conversation

@AgnieszkaZaba

@AgnieszkaZaba AgnieszkaZaba commented Apr 19, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@AgnieszkaZaba
new ga plot
d35da6b
@AgnieszkaZaba
Revert "Refine citation with DOI link (open-atmos#1813)"
cb47394 
This reverts commit 2b58ab4.
@AgnieszkaZaba
add r to string formatting; update temperature
fae09de
@AgnieszkaZaba
plot update
7d0074d
@AgnieszkaZaba
set dm dependence on RH
17fbfab
@AgnieszkaZaba
pristine vs polluted
1988345
@AgnieszkaZaba
add label
6e2a7f1
@AgnieszkaZaba
comparison for pristine and polluted?
590bde5
@AgnieszkaZaba
plots with swm const
91d22af
@AgnieszkaZaba
dm_dt total is the same
942b91c
@AgnieszkaZaba
dm_dt total is the same, fix
4c3c350
@AgnieszkaZaba
add delta on z axis; new plot for pristine vs polluted (2D)
7bb9595
@AgnieszkaZaba
make plots beautiful
72a76fd
@AgnieszkaZaba
add description
5be98bb
@AgnieszkaZaba
Bolin number in return, asserts
75fe80d
@AgnieszkaZaba
add removed todo
a298b61
@AgnieszkaZaba
fix units in test
bf7ddbe
@AgnieszkaZaba
fix Bolin formula; units were wrong
a42b788
@AgnieszkaZaba
remove dependence on time from Bo and dR/dt; small fixes
cfb2d19
@AgnieszkaZaba
remove Bo calculation (was for debug)
ba1160c
@AgnieszkaZaba
figure for iso equil using Bo
4ecb3c5
@AgnieszkaZaba
insert values in text; small cleanup - remove attr used once
dcb8956
@AgnieszkaZaba
separate code, move to new files
6e224d4
@AgnieszkaZaba
use Fd in Bolin formula
b7cacc0
@AgnieszkaZaba
add saturation for zero dR condition using Fk and Fd, without b
5e8b08b
@AgnieszkaZaba
new plot for S eq using ZabaEtAl formula; cleanup plotting
5f60371
@AgnieszkaZaba AgnieszkaZaba self-assigned this Apr 19, 2026
@slayoo slayoo changed the title isotopic ratio evolution in simulation; Bolin number isotopic ratio evolution in a single-timestep simulation using Bolin number (with plots depicting Gedzelman & Arnold condition for different droplet concentrations) Apr 29, 2026
@slayoo slayoo mentioned this pull request May 23, 2026
Closed
slayoo
slayoo requested changes May 30, 2026
View reviewed changes
Comment thread PySDM/backends/impl_numba/methods/isotope_methods.py Outdated
Comment thread PySDM/physics/isotope_ratio_evolution/zaba_et_al.py Outdated
Comment thread PySDM/physics/isotope_relaxation_timescale/zaba_et_al.py
Comment thread examples/PySDM_examples/Gedzelman_and_Arnold_1994/fig_2.ipynb
AgnieszkaZaba and others added 14 commits June 10, 2026 21:02
@AgnieszkaZaba
add test GA vs Z
bf1168c
@AgnieszkaZaba
Merge branch 'main' into bo-with-simulation
cc8850b
@AgnieszkaZaba
Merge branch 'main' into bo-with-simulation
bf2be0f
@AgnieszkaZaba
Merge remote-tracking branch 'refs/remotes/origin/bo-with-simulation'…
dab4d80 
… into bo-with-simulation
@AgnieszkaZaba
remove resolvd todo flag
caa975e
@AgnieszkaZaba
use unused variable
43b768c
@AgnieszkaZaba
remove redundant class
5c4a01f
@AgnieszkaZaba
cache getattr
4ba10ac
@AgnieszkaZaba
change import order
e7d37dd
@AgnieszkaZaba
remove not needed function, add comment about the derivation, fix R&Y…
5c13997 
… citation year; clean bilbiography
@AgnieszkaZaba
Change placement of f_ratio argument as it is per droplet and not onl…
12c9416 
…y per isotope; update comment to mention the ommitance (is this a word?:) )
@AgnieszkaZaba
remove unused import
3d6c2b6
@AgnieszkaZaba
remove unused parameter, specify heavy_to_light in D_ratio name
820c7f0
@AgnieszkaZaba
rerun notebook after changes
2e4147b
@AgnieszkaZaba AgnieszkaZaba mentioned this pull request Jun 19, 2026
Closed
@AgnieszkaZaba AgnieszkaZaba requested a review from slayoo June 19, 2026 12:49
@slayoo

slayoo commented Jun 19, 2026

Copy link
Copy Markdown
Member

@AgnieszkaZaba, I have no more comments to the code, but the PR title doesn't seem to match the contents:

  • are the different droplet concentrations there?
  • the isotope fractionation dynamic seems to have been handling multiple isotopes even before this PR
  • there doesn't seem to be any simulation being executed here, right?

@slayoo

slayoo commented Jun 20, 2026

Copy link
Copy Markdown
Member

@AgnieszkaZaba, please adjust the title and merge

@AgnieszkaZaba AgnieszkaZaba changed the title other isotopes in isotopic fractionation dynamic; isotopic ratio evolution in a single-timestep simulation using Bolin number (with plots depicting Gedzelman & Arnold condition for different droplet concentrations) other isotopes in isotope methods; cache D_ratio and alpha in isotopic fractionation; add diffusivity ratios using Grahams law for other isotopes Jun 22, 2026
@AgnieszkaZaba AgnieszkaZaba changed the title other isotopes in isotope methods; cache D_ratio and alpha in isotopic fractionation; add diffusivity ratios using Grahams law for other isotopes other isotopes in isotope methods; cache D_ratio and alpha in bolin_number; add diffusivity ratios using Grahams law for other isotopes; tests for Bolin number Jun 22, 2026
@AgnieszkaZaba AgnieszkaZaba enabled auto-merge June 22, 2026 09:11
@AgnieszkaZaba AgnieszkaZaba disabled auto-merge June 22, 2026 09:11
@AgnieszkaZaba AgnieszkaZaba merged commit f942453 into open-atmos:main Jun 22, 2026
99 checks passed
@AgnieszkaZaba

AgnieszkaZaba commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

@slayoo Thank you!
I left other isotopes in title as it was hardcoded for 2H in isotope_methods.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slayoo slayoo Awaiting requested review from slayoo

Assignees

@AgnieszkaZaba AgnieszkaZaba

Labels

isotopes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AgnieszkaZaba @slayoo