Merge remote-tracking branch 'upstream/main' into fix/normalize-cli-command-quotes

Author: jeffrey-takuma

.github/actions/setup/action.yml

@@ -21,15 +21,15 @@ runs:
         package-manager-cache: false
 
     - name: Install pnpm
-      uses: pnpm/action-setup@v4
+      uses: pnpm/action-setup@v6
 
     - name: Get pnpm store directory
       id: pnpm-cache-dir
       shell: bash
       run: echo "dir=$(pnpm store path)" >> $GITHUB_OUTPUT
 
     - name: Setup pnpm cache
-      uses: actions/cache@v4
+      uses: actions/cache@v5
       with:
         path: ${{ steps.pnpm-cache-dir.outputs.dir }}
         key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}

README.md

@@ -3,7 +3,7 @@
 [![Latest Release](https://img.shields.io/github/v/release/open-cli-tools/concurrently?label=Release)](https://github.com/open-cli-tools/concurrently/releases)
 [![License](https://img.shields.io/github/license/open-cli-tools/concurrently?label=License)](https://github.com/open-cli-tools/concurrently/blob/main/LICENSE)
 [![Weekly Downloads on NPM](https://img.shields.io/npm/dw/concurrently?label=Downloads&logo=npm)](https://www.npmjs.com/package/concurrently)
-[![CI Status](https://img.shields.io/github/actions/workflow/status/open-cli-tools/concurrently/test.yml?label=CI&logo=github)](https://github.com/open-cli-tools/concurrently/actions/workflows/test.yml)
+[![CI Status](https://img.shields.io/github/actions/workflow/status/open-cli-tools/concurrently/ci.yml?label=CI&logo=github)](https://github.com/open-cli-tools/concurrently/actions/workflows/ci.yml)
 [![Coverage Status](https://img.shields.io/coveralls/github/open-cli-tools/concurrently/main?label=Coverage&logo=coveralls)](https://coveralls.io/github/open-cli-tools/concurrently?branch=main)
 
 Run multiple commands concurrently.
@@ -112,6 +112,8 @@ Check out documentation and other usage examples in the [`docs` directory](./doc
     Possible values: `index`, `pid`, `time`, `command`, `name`, `none`, or a template (eg `[{time} process: {pid}]`).
     Default: the name of the process, or its index if no name is set.
   - `prefixColors`: a list of colors or a string as supported by [Chalk](https://www.npmjs.com/package/chalk) and additional style `auto` for an automatically picked color.
+    Supports all Chalk color functions: `#RRGGBB`, `bg#RRGGBB`, `hex()`, `bgHex()`, `rgb()`, `bgRgb()`, `ansi256()`, `bgAnsi256()`.
+    Functions and modifiers can be chained (e.g., `rgb(255,136,0).bold`, `black.bgHex(#00FF00).dim`).
     If concurrently would run more commands than there are colors, the last color is repeated, unless if the last color value is `auto` which means following colors are automatically picked to vary.
     Prefix colors specified per-command take precedence over this list.
   - `prefixLength`: how many characters to show when prefixing with `command`. Default: `10`

bin/index.ts

@@ -7,7 +7,7 @@ import { hideBin } from 'yargs/helpers';
 import { assertDeprecated } from '../lib/assert.js';
 import * as defaults from '../lib/defaults.js';
 import { concurrently } from '../lib/index.js';
-import { castArray } from '../lib/utils.js';
+import { castArray, splitOutsideParens } from '../lib/utils.js';
 import { normalizeCliCommand } from './normalize-cli-command.js';
 import { readPackageJson } from './read-package-json.js';
 
@@ -257,7 +257,7 @@ concurrently(
         hide: args.hide.split(','),
         group: args.group,
         prefix: args.prefix,
-        prefixColors: args.prefixColors.split(','),
+        prefixColors: splitOutsideParens(args.prefixColors, ','),
         prefixLength: args.prefixLength,
         padPrefix: args.padPrefix,
         restartDelay:

docs/cli/prefixing.md

@@ -118,6 +118,34 @@ $ concurrently -c bgGray,red.bgBlack 'echo Hello there' 'echo General Kenobi!'
 - `bgYellow`
 </details>
 
+### Advanced Color Functions
+
+concurrently supports all [Chalk color functions](https://github.com/chalk/chalk#256-and-truecolor-color-support):
+
+| Function         | Description                 |
+| ---------------- | --------------------------- |
+| `#RRGGBB`        | Foreground hex (shorthand)  |
+| `bg#RRGGBB`      | Background hex (shorthand)  |
+| `hex(#RRGGBB)`   | Foreground hex              |
+| `bgHex(#RRGGBB)` | Background hex              |
+| `rgb(R,G,B)`     | Foreground RGB (0-255)      |
+| `bgRgb(R,G,B)`   | Background RGB (0-255)      |
+| `ansi256(N)`     | Foreground ANSI 256 (0-255) |
+| `bgAnsi256(N)`   | Background ANSI 256 (0-255) |
+
+All functions can be chained with colors and modifiers:
+
+```bash
+# Hex colors
+$ concurrently -c 'bg#FF0000.bold,black.bgHex(#00FF00).dim' 'echo Red bg' 'echo Green bg'
+
+# RGB colors
+$ concurrently -c 'rgb(255,136,0).bold,black.bgRgb(100,100,255)' 'echo Orange' 'echo Blue bg'
+
+# ANSI 256 colors
+$ concurrently -c 'ansi256(199),ansi256(50).bgAnsi256(17)' 'echo Pink' 'echo Cyan on blue'
+```
+
 ## Prefix Length
 
 When using the `command` prefix style, it's possible that it'll be too long.<br/>

lib/assert.spec.ts

@@ -1,14 +1,17 @@
-import { afterEach, describe, expect, it, vi } from 'vitest';
+import { afterEach, beforeEach, describe, expect, it, MockInstance, vi } from 'vitest';
 
-import { assertDeprecated } from './assert.js';
+import { assertDeprecated, assertNotRuntime } from './assert.js';
 
-describe('#assertDeprecated()', () => {
-    const consoleMock = vi.spyOn(console, 'warn').mockImplementation(() => {});
+let consoleMock: MockInstance;
+beforeEach(() => {
+    consoleMock = vi.spyOn(console, 'warn').mockImplementation(() => {});
+});
 
-    afterEach(() => {
-        vi.clearAllMocks();
-    });
+afterEach(() => {
+    vi.clearAllMocks();
+});
 
+describe('assertDeprecated()', () => {
     it('prints warning with name and message when condition is false', () => {
         assertDeprecated(false, 'example-flag', 'This is an example message.');
 
@@ -33,3 +36,29 @@ describe('#assertDeprecated()', () => {
         expect(consoleMock).not.toHaveBeenCalled();
     });
 });
+
+describe('assertNotRuntime()', () => {
+    it('prints warning with name and message when condition is false', () => {
+        assertNotRuntime(false, 'example-flag', 'This is an example message.');
+
+        expect(consoleMock).toHaveBeenLastCalledWith(
+            '[concurrently] Running via example-flag is not well supported. This is an example message.',
+        );
+    });
+
+    it('prints same warning only once', () => {
+        assertNotRuntime(false, 'example-flag', 'This is an example message.');
+        assertNotRuntime(false, 'different-flag', 'This is another message.');
+
+        expect(consoleMock).toBeCalledTimes(1);
+        expect(consoleMock).toHaveBeenLastCalledWith(
+            '[concurrently] Running via different-flag is not well supported. This is another message.',
+        );
+    });
+
+    it('prints nothing if condition is true', () => {
+        assertNotRuntime(true, 'example-flag', 'This is an example message.');
+
+        expect(consoleMock).not.toHaveBeenCalled();
+    });
+});

lib/assert.ts

@@ -11,3 +11,17 @@ export function assertDeprecated(check: boolean, name: string, message: string)
         deprecations.add(name);
     }
 }
+
+const runtimes = new Set<string>();
+
+/**
+ * Asserts that some condition is true, and if not, prints a warning about the runtime not being well supported.
+ * The message is printed only once.
+ */
+export function assertNotRuntime(check: boolean, name: string, message: string) {
+    if (!check && !runtimes.has(name)) {
+        // eslint-disable-next-line no-console
+        console.warn(`[concurrently] Running via ${name} is not well supported. ${message}`);
+        runtimes.add(name);
+    }
+}

lib/completion-listener.spec.ts

@@ -255,7 +255,7 @@ describe('detect commands exit conditions', () => {
             return expect(result).rejects.toEqual(expect.anything());
         });
 
-        it(`fails if some commands ${nameOrIndex} exit with non-0 code`, () => {
+        it(`succeeds if command ${nameOrIndex} exits with code 0 even when others fail`, () => {
             const result = createController(condition).listen(commands);
 
             emitFakeCloseEvent(commands[0], { exitCode: 1 });

lib/index.ts

@@ -1,7 +1,7 @@
 import process from 'node:process';
 import { Readable } from 'node:stream';
 
-import { assertDeprecated } from './assert.js';
+import { assertDeprecated, assertNotRuntime } from './assert.js';
 import { CloseEvent, Command, CommandIdentifier, TimerEvent } from './command.js';
 import {
     concurrently as createConcurrently,
@@ -127,6 +127,14 @@ export function concurrently(
     options: Partial<ConcurrentlyOptions> = {},
 ) {
     assertDeprecated(options.killOthers === undefined, 'killOthers', 'Use killOthersOn instead.');
+    assertNotRuntime(
+        // When run via /snap/bin/node, process.execPath maps to the actual snap path, but it also sets
+        // several SNAP_* env variables. If the snap is run directly via e.g. /snap/node/current/bin/node,
+        // the issues don't happen and no env variables are set.
+        !String(process.env.SNAP).startsWith('/snap'),
+        'Snap',
+        'Snap confinement can interfere with spawning child processes. See issue #584',
+    );
 
     // To avoid empty strings from hiding the output of commands that don't have a name,
     // keep in the list of commands to hide only strings with some length.