Skip to content

fix: scope quote normalization to CLI input#585

Open
jeffrey-takuma wants to merge 5 commits intoopen-cli-tools:mainfrom
jeffrey-takuma:fix/normalize-cli-command-quotes
Open

fix: scope quote normalization to CLI input#585
jeffrey-takuma wants to merge 5 commits intoopen-cli-tools:mainfrom
jeffrey-takuma:fix/normalize-cli-command-quotes

Conversation

@jeffrey-takuma
Copy link
Copy Markdown

Summary

Scope quote normalization to CLI input instead of the library API.

This moves the outer-quote normalization logic out of lib/concurrently.ts and into the CLI entrypoint, so well-formed shell commands keep their quotes when using the library API.

Closes #582

Changes

  • remove StripQuotes from lib/concurrently.ts
  • add bin/normalize-cli-command.ts for CLI-only command normalization
  • normalize CLI commands in bin/index.ts before calling concurrently()
  • add coverage for CLI normalization in bin/normalize-cli-command.spec.ts
  • add coverage for preserving quotes in the library API in lib/concurrently.spec.ts
  • add a thin CLI integration test in bin/index.spec.ts

Tests

  • pnpm test

@jeffrey-takuma
Copy link
Copy Markdown
Author

Opened this PR for #582.

The test jobs are passing on the PR. The only failing check seems to be the coverage upload step, which is currently returning a Coveralls 504 timeout.

@jeffrey-takuma jeffrey-takuma force-pushed the fix/normalize-cli-command-quotes branch from 0c04c54 to d0a082b Compare April 21, 2026 06:22
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — jeffrey-takuma:fix/normalize-cli-command-quotes into open-cli-tools:main

@jeffrey-takuma
Copy link
Copy Markdown
Author

@gustavohenke
I opened this PR to address #582, and it should be ready for review now. Could you take a look when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StripQuotes regex incorrectly strips outer quotes from well-formed shell commands

2 participants