fix: scope quote normalization to CLI input#585
Open
jeffrey-takuma wants to merge 5 commits intoopen-cli-tools:mainfrom
Open
fix: scope quote normalization to CLI input#585jeffrey-takuma wants to merge 5 commits intoopen-cli-tools:mainfrom
jeffrey-takuma wants to merge 5 commits intoopen-cli-tools:mainfrom
Conversation
Author
|
Opened this PR for #582. The test jobs are passing on the PR. The only failing check seems to be the coverage upload step, which is currently returning a Coveralls |
jeffrey-takuma
force-pushed
the
fix/normalize-cli-command-quotes
branch
from
0c04c54 to
d0a082b
Compare
|
coverage: 100.0%. remained the same — jeffrey-takuma:fix/normalize-cli-command-quotes into open-cli-tools:main |
Author
|
@gustavohenke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope quote normalization to CLI input instead of the library API.
This moves the outer-quote normalization logic out of
lib/concurrently.tsand into the CLI entrypoint, so well-formed shell commands keep their quotes when using the library API.Closes #582
Changes
StripQuotesfromlib/concurrently.tsbin/normalize-cli-command.tsfor CLI-only command normalizationbin/index.tsbefore callingconcurrently()bin/normalize-cli-command.spec.tslib/concurrently.spec.tsbin/index.spec.tsTests
pnpm test