Skip to content

fix(coap-core): add mapping for 204 http status to C205_CONTENT code #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szysas merged 1 commit into from
Mar 31, 2026
Merged

fix(coap-core): add mapping for 204 http status to C205_CONTENT code #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions coap-core/src/main/java/com/mbed/coap/packet/Code.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ public boolean isSuccess() {
return coapCode >>> 5 == 2;
}

@SuppressWarnings("PMD.NcssCount")
public static Code fromHttp(int httpStatus, Method method) {

switch (httpStatus) {
Expand All @@ -127,11 +128,15 @@ public static Code fromHttp(int httpStatus, Method method) {
case 201:
return C201_CREATED;
case 204:
if (method == Method.DELETE) {
return C202_DELETED;
switch (method) {
case GET:
case FETCH:
return C205_CONTENT;
case DELETE:
return C202_DELETED;
default:
return C204_CHANGED;
}
return C204_CHANGED;


// REDIRECT (3.xx)
case 304:
Expand Down
1 change: 1 addition & 0 deletions coap-core/src/test/java/com/mbed/coap/packet/CodeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public void shouldConvertHttpToCoapCode() {
assertEquals(Code.C201_CREATED, fromHttp(202, POST));
assertEquals(Code.C202_DELETED, fromHttp(202, DELETE));
assertEquals(Code.C202_DELETED, fromHttp(204, DELETE));
assertEquals(Code.C205_CONTENT, fromHttp(204, GET));

assertEquals(Code.C203_VALID, fromHttp(304, GET));

Expand Down
Loading