[Fix] Correct LOCAL_RANK default value to 0 in run.py#1593
Open
pranaysb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1589
Description
In
run.py,LOCAL_RANKwas being read from the environment with an incorrect default value of1. IfLOCAL_WORLD_SIZEis set butLOCAL_RANKis not, this default causes the GPU assignment block to skip the first GPU partition (DEVICE_START_IDX = GPU_PER_PROC * 1).This PR corrects the default value of
LOCAL_RANKto0.Root Cause & Justification
torchrunconventions state thatLOCAL_RANKalways starts at0.RANKvariable inrun.py:33correctly defaults to0, andLOCAL_RANKshares the exact same semantic concept.LOCAL_RANKread across this codebase correctly defaults to0(seevlmeval/vlm/emu.py:76,vlmeval/vlm/parrot.py:61, andvlmeval/vlm/parrot.py:188).Verification
pre-commit run --all-filespassed successfully.flake8checks onrun.pypassed cleanly (ignoringW503as persetup.cfg/.pre-commit-config.yaml).git diffshows exactly one line changed.