chore: adopt Community Specification License 1.0#139
Conversation
morri-son
left a comment
morri-son
left a comment
There was a problem hiding this comment.
lgtm, just remove the markdown linter issues
|
We cannot modify these. Even if markdown fails, these are the files that need to exist in this format. The Notices we will change, yes. But not the License. |
|
@jakobmoellerdev Can I merge this even with the failures? |
|
Okay, I updated the License and the Notices and added a missing file and updated the Scope. For the Scope I copied some of the descriptions right from the license and than added the points I saw necessary. I looked at a bunch of scope files that you can find on Github :). For example: https://github.com/slsa-framework/governance/blob/c3e9b27157ac28e79248a264e5b4bab8732f8a23/2._Scope.md?plain=1#L4 So I tried to keep it very brief. @jakobmoellerdev please see if the scope makes sense. |
|
@jakobmoellerdev Might want to involve some legal peeps on the Scope? :) |
|
I have been given guidance from Legal to take a look at https://github.com/finos/FDC3/blob/main/SCOPE.md for a good scope document |
|
Thanks! I actually saw that hahaha. Okay. |
|
@jakobmoellerdev Okay. I literally took that thing and tried mostly to replicate it by linking to our own docs. :) WDYT? |
| SPDX-PackageComment = "The code in this project may include calls to APIs (\"API Calls\") of\n SAP or third-party products or services developed outside of this project\n (\"External Products\").\n \"APIs\" means application programming interfaces, as well as their respective\n specifications and implementing code that allows software to communicate with\n other software.\n API Calls to External Products are not licensed under the open source license\n that governs this project. The use of such API Calls and related External\n Products are subject to applicable additional agreements with the relevant\n provider of the External Products. In no event shall the open source license\n that governs this project grant any rights in or to any External Products, or\n alter, expand or supersede any terms of the applicable additional agreements.\n If you have a valid license agreement with SAP for the use of a particular SAP\n External Product, then you may make use of any API Calls included in this\n project's code for that SAP External Product, subject to the terms of such\n license agreement. If you do not have a valid license agreement for the use of\n a particular SAP External Product, then you may only make use of any API Calls\n in this project for that SAP External Product for your internal, non-productive\n and non-commercial test and evaluation of such API Calls. Nothing herein grants\n you any rights to use or access any SAP External Product, or provide any third\n parties the right to use of access any SAP External Product, through API Calls." | ||
|
|
||
| [[annotations]] | ||
| path = "**" |
There was a problem hiding this comment.
why dont you switch all of the content to this license? we are reclicensing spec after all in its entirety no?
There was a problem hiding this comment.
I recall a conversation that some of the stuff is still apache license because it's code or example or something like that? 🤔 For example, are you sure it's the same license for the stuff under scripts? If so, I'm happy to just blanket license everything.
There was a problem hiding this comment.
the only script is a table of contents generator which is probably a gray area :D
There was a problem hiding this comment.
Okay, I'll do this :) and update the FileCopyrightText to point to the long form of the license.
There was a problem hiding this comment.
Okay done. What I don't know is if the FileCopyrightText is good or not... 🤔
There was a problem hiding this comment.
don't we need to remove SAP SE from all parts of the license?
There was a problem hiding this comment.
Unsure. :D I'll let the legal team decide here. :)
There was a problem hiding this comment.
My next sync with legal is on monday.
There was a problem hiding this comment.
To keep SAP attribution preserved, I mentioned both in SPDX-FileCopyrightText. I guess this is ok. But I removed the SAP specific boilerplate from SPDX-PackageComment, as for the future only LFS should be mentioned.
There was a problem hiding this comment.
We'll see what legal has to say about it. :)
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
force-pushed
the
add-license
branch
2 times, most recently
from
52525e6 to
aa249df
Compare
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
jakobmoellerdev
changed the title
3 participants
What this PR does / why we need it
First pass for open-component-model/ocm-project#939.
Fixes open-component-model/ocm-project#982
This PR adds the necessary files without modification to expand on those that are needed expansion after the copy.
Next PR will make sure the Scope.md and the Notices.md is filled out with the correct information.
Which issue(s) this PR is related to