validation

Signed-off-by: Piotr Janik <piotr.janik@sap.com>

Author: piotrjanik

api/oci/extensions/repositories/ocireg/timeout_integration_test.go

@@ -51,19 +51,19 @@ var _ = Describe("Registry timeout:", Ordered, func() {
 
 		var err error
 		nw, err = network.New(ctx)
-		Expect(err).To(Succeed(), "failed to create Docker network")
+		Expect(err).ToNot(HaveOccurred(), "failed to create Docker network")
 
 		registryContainer, err = registry.Run(ctx, registryImage,
 			network.WithNetwork([]string{"registry"}, nw),
 			testcontainers.WithWaitStrategy(wait.ForHTTP("/v2/").WithPort("5000/tcp")),
 		)
-		Expect(err).To(Succeed(), "failed to start registry container")
+		Expect(err).ToNot(HaveOccurred(), "failed to start registry container")
 
 		toxiContainer, err = tctoxiproxy.Run(ctx, toxiproxyImage,
 			network.WithNetwork([]string{"toxiproxy"}, nw),
 			tctoxiproxy.WithProxy(proxyName, fmt.Sprintf("registry:%d", registryPort)),
 		)
-		Expect(err).To(Succeed(), "failed to start toxiproxy container")
+		Expect(err).ToNot(HaveOccurred(), "failed to start toxiproxy container")
 
 		host, port, err := toxiContainer.ProxiedEndpoint(8666)
 		Expect(err).ToNot(HaveOccurred())
@@ -73,7 +73,7 @@ var _ = Describe("Registry timeout:", Ordered, func() {
 		Expect(err).ToNot(HaveOccurred())
 		toxiClient := toxiproxy.NewClient(uri)
 		proxy, err = toxiClient.Proxy(proxyName)
-		Expect(err).To(Succeed(), "failed to get toxiproxy proxy")
+		Expect(err).ToNot(HaveOccurred(), "failed to get toxiproxy proxy")
 
 		env = NewTestEnv(envhelper.FileSystem(osfs.New()))
 

api/utils/httpclient/transport_test.go

@@ -87,6 +87,14 @@ var _ = Describe("NewTransport", func() {
 			Expect(tr.DialContext).NotTo(BeNil())
 			Expect(tr.TLSHandshakeTimeout).To(Equal(defaultTransport.TLSHandshakeTimeout))
 		})
+
+		It("replaces DialContext when negative TCPKeepAlive disables probes", func() {
+			tr, err := httpclient.NewTransport(&ocicpi.HTTPSettings{
+				TCPKeepAlive: dur("-1s"),
+			})
+			Expect(err).To(Succeed())
+			Expect(tr.DialContext).NotTo(BeNil())
+		})
 	})
 
 	Context("when all fields are set", func() {