feat: configurable preference for relative access creation for uploader#1412
Merged
Merged
Conversation
github-actions
Bot
added
area/documentation
- use relative access methods for OCI upload to local OCM repository - make preference configurable for repos
jakobmoellerdev
requested changes
Apr 29, 2025
Member
jakobmoellerdev
left a comment
jakobmoellerdev
left a comment
There was a problem hiding this comment.
In general, relativeOciAccesses are not nicely specified and theyre already not part of the spec anymore. Nevertheless I recognize the value this gives for local debugging.
For me this PR is acceptable, but only if we mark the type as experimental somehow. I think relativeOciAccesses should be avoided because most tools will only know how to deal with ociArtifact / ociImage. Introducing yet another type that is only resolvable if a context is known is very dangerous.
Contributor
|
This pull request was marked as stale because it has not had recent activity. |
github-actions
Bot
added
the
lifecycle/stale
Skarlso
removed
the
lifecycle/stale
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Contributor
|
Added an experimental warning. |
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> On-behalf-of: gergely.brautigam@sap.com
jakobmoellerdev
approved these changes
Sep 4, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
By default the OCI uploader used to handle the implicit OCI uploads for OCI based OCM repositories
creates an absolute access method.
A new global attribute
preferrelativeaccess(bool) can be used now to switch this behaviorto prefer a relative access method.
With the new config object
local.oci.uploader.config.ocm.softwareit is possible to configurehost/port combinations for which the relative access should be preferred. (For example
localhost).Which issue(s) this PR fixes
Fixes #1410