Conversation
github-actions
Bot
added
kind/chore
frewilhelm
reviewed
Apr 29, 2025
Contributor
frewilhelm
left a comment
frewilhelm
left a comment
There was a problem hiding this comment.
This pin will be recognised by dependabot, right?
Member
Author
nope, I don't think so. I haven't seen any samples where Dependabot automatically checked Makefiles... That would require some custom dependabot config. |
jakobmoellerdev
approved these changes
Apr 29, 2025
| mdref: | ||
| # https://github.com/mandelsoft/mdref/issues/1 as workaround set GONOSUMDB | ||
| GONOSUMDB='github.com/mandelsoft/mdref' go install -v github.com/mandelsoft/mdref@v0.5.0 | ||
| go install -v github.com/mandelsoft/mdref@v0.5.1 |
Contributor
There was a problem hiding this comment.
It used to pin @master before failure. Do we want to stick to a specific version now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mandelsoft created a new tag: https://github.com/mandelsoft/mdref/releases/tag/v0.5.1 which doesn't result in sha-sum mismatches.
What this PR does / why we need it
We should not use the ugly workaround with the
GONOSUMDBsetting.Which issue(s) this PR fixes
fixes: mandelsoft/mdref#1