chore: golangci lint/v2 #1434
Merged
Merged
Conversation
#### What this PR does / why we need it I was checking originally on the linter issues in https://github.com/open-component-model/ocm-k8s-toolkit and realizing, that there is a newer version of `golangci-lint` available. This PR upgrades to golangci-lint v2.1.5. I've followed the https://golangci-lint.run/product/migration-guide/ and then added some more exclusions: https://github.com/open-component-model/ocm/blob/d50bee9eac6f2ec6b4816dc754291f085f4ab5bd/.github/config/golangci.yaml#L141-L172 until no more errors occurred. Not sure if someone wants to fix some of those `staticcheck`.
github-actions
Bot
added
kind/chore
frewilhelm
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2nd try, because 1st did include unsigned commits
What this PR does / why we need it
I was checking originally on the linter issues in
https://github.com/open-component-model/ocm-k8s-toolkit and realizing, that there is a newer version of
golangci-lintavailable.This PR upgrades to golangci-lint v2.1.5.
I've followed the https://golangci-lint.run/product/migration-guide/ and then added some more exclusions:
ocm/.github/config/golangci.yaml
Lines 141 to 172 in d50bee9
until no more errors occurred.
Not sure if someone wants to fix some of those
staticcheck.What this PR does / why we need it
Which issue(s) this PR fixes