fix: allow pre-v3.7.0 HELM Charts in HELM OCI Artifact downloader (#1476)#1479
Merged
jakobmoellerdev merged 1 commit intoMay 21, 2025
Conversation
…en-component-model#1476) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it The release of Helm v3.7.0 included the implementation of HIP 6 for OCI support. The chart layer media type was switched from application/tar+gzip to application/vnd.cncf.helm.chart.content.v1.tar+gzip. To support HELM Charts created before this version, we should maintain compatibility with a legacy layer detection. This implements this detection to make sure we don't have breaking changes after our recent adjustment to media type based checking. See https://helm.sh/docs/topics/registries/#oci-feature-deprecation-and-behavior-changes-with-v370 for context #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> fix open-component-model#1469 relates to open-component-model#1470 and needs to be backported the same (cherry picked from commit 729a19f)
Skarlso
approved these changes
May 21, 2025
jakobmoellerdev
merged commit 2817b07
into
open-component-model:releases/v0.23
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The release of Helm v3.7.0 included the implementation of HIP 6 for OCI support. The chart layer media type was switched from application/tar+gzip to
application/vnd.cncf.helm.chart.content.v1.tar+gzip.
To support HELM Charts created before this version, we should maintain compatibility with a legacy layer detection.
This implements this detection to make sure we don't have breaking changes after our recent adjustment to media type based checking.
See
https://helm.sh/docs/topics/registries/#oci-feature-deprecation-and-behavior-changes-with-v370 for context
Which issue(s) this PR fixes
fix #1469
relates to #1470 and needs to be backported the same
(cherry picked from commit 729a19f)