fix!: unwrap standard transfer handler and fix spiff handler#1501
Merged
jakobmoellerdev merged 3 commits intoSep 10, 2025
Merged
Conversation
github-actions
Bot
added
!BREAKING-CHANGE!
fabianburth
force-pushed
the
fix/omit-access-types
branch
from
436a7cd to
5f34226
Compare
frewilhelm
reviewed
Jun 6, 2025
Contributor
|
This pull request was marked as stale because it has not had recent activity. |
github-actions
Bot
added
the
lifecycle/stale
fabianburth
force-pushed
the
fix/omit-access-types
branch
from
5f34226 to
0d8fcaf
Compare
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
fabianburth
force-pushed
the
fix/omit-access-types
branch
from
819c121 to
8f70d76
Compare
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
jakobmoellerdev
approved these changes
Sep 10, 2025
fabianburth
added a commit
to fabianburth/ocm
that referenced
this pull request
Sep 10, 2025
…mponent-model#1501) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it - Make `ocm transfer {cv|ctf}` respect `--omit-access-types` (as originally intended). - Unwrap the standard transfer handler so omit logic is applied consistently across handlers. - Fix spiff handler so it no longer reinstates access types when omit is requested. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Previously, users might have used the flag `--omit-access-types` with a transfer and would have changed behavior now (flag was ignored). After this change, `--omit-access-types` takes effect for any transfer as originally intended. **Users expecting resources to be transferred even though they were mentioned with their access type in `--omit-access-types` must likely drop `--omit-access-types` for that access type if they used it before and expected the resources to still be present.** Fixes open-component-model#1500 --------- Signed-off-by: Fabian Burth <fabian.burth@sap.com> (cherry picked from commit 479f138)
jakobmoellerdev
pushed a commit
that referenced
this pull request
Sep 10, 2025
…1617) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it - Make `ocm transfer {cv|ctf}` respect `--omit-access-types` (as originally intended). - Unwrap the standard transfer handler so omit logic is applied consistently across handlers. - Fix spiff handler so it no longer reinstates access types when omit is requested. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Previously, users might have used the flag `--omit-access-types` with a transfer and would have changed behavior now (flag was ignored). After this change, `--omit-access-types` takes effect for any transfer as originally intended. **Users expecting resources to be transferred even though they were mentioned with their access type in `--omit-access-types` must likely drop `--omit-access-types` for that access type if they used it before and expected the resources to still be present.** Fixes #1500 --------- (cherry picked from commit 479f138) Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
ocm transfer {cv|ctf}respect--omit-access-types(as originally intended).Which issue(s) this PR fixes
Previously, users might have used the flag
--omit-access-typeswith a transfer and would have changed behavior now (flag was ignored).After this change,
--omit-access-typestakes effect for any transfer as originally intended.Users expecting resources to be transferred even though they were mentioned with their access type in
--omit-access-typesmust likely drop--omit-access-typesfor that access type if they used it before and expected the resources to still be present.Fixes #1500