chore: fix the transport leak in getResolver#1918
Merged
Skarlso merged 2 commits intoopen-component-model:mainfrom Apr 15, 2026
Merged
chore: fix the transport leak in getResolver#1918Skarlso merged 2 commits intoopen-component-model:mainfrom
Skarlso merged 2 commits intoopen-component-model:mainfrom
Conversation
Skarlso
force-pushed
the
fix-leaking-tcp-connection-2
branch
from
62eefc2 to
c683ab0
Compare
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
force-pushed
the
fix-leaking-tcp-connection-2
branch
2 times, most recently
from
495aaa6 to
bde4884
Compare
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
force-pushed
the
fix-leaking-tcp-connection-2
branch
from
bde4884 to
651324f
Compare
jakobmoellerdev
approved these changes
Apr 15, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Partial fix for open-component-model/ocm-project#778. It fixes the TCP connection leak problem.
This PR has been tested by Dan in this comment: open-component-model/ocm-project#778 (comment)
Note: This is now slightly cleaner than what Dan tested but has the same principle. I just shifted the creation of the transport into
NewRepositoryfunction.Which issue(s) this PR is related to