Skip to content

fix: incompatibilities between v1 and v2#1992

Merged
jakobmoellerdev merged 13 commits into
open-component-model:mainfrom
frewilhelm:compat-v1-v2-access-types
Jun 29, 2026
Merged

fix: incompatibilities between v1 and v2#1992
jakobmoellerdev merged 13 commits into
open-component-model:mainfrom
frewilhelm:compat-v1-v2-access-types

Conversation

@frewilhelm

@frewilhelm frewilhelm commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

OCM v2 accepts a broader set of canonical and alias type names than v1 currently registers — for example OCIImage, OCIImageLayer, LocalBlob, and /v1-suffixed variants of every input type. This PR teaches v1 to decode, recognise, and round-trip those names so descriptors written by v2 deserialize correctly through the v1 stack.

  • Add missing aliases for access and input
  • Replace direct GetKind() == localblob.Type comparisons with localblob.Is(a) in comparch, genericocireg, and virtual repository implementations.
  • fixes the consumer-type literal (OCIRepository -> OCIRegistry), adds --tmpfs /tmp:exec to the docker invocations, and bumps the CLI image to :latest.

Which issue(s) this PR is related to

Contributes to #1979

@github-actions github-actions Bot added the size/m Medium label Jun 5, 2026
@frewilhelm frewilhelm changed the title add unit tests to make sure accessmethods are resolved correctly fix: fix incompatibilities between v1 and v2 Jun 5, 2026
@github-actions github-actions Bot added the kind/bugfix Bug label Jun 5, 2026
@frewilhelm frewilhelm changed the title fix: fix incompatibilities between v1 and v2 fix: incompatibilities between v1 and v2 Jun 5, 2026
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm force-pushed the compat-v1-v2-access-types branch from 539adc2 to 4eb9072 Compare June 10, 2026 15:05
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@github-actions github-actions Bot added the component/ocm-cli OCM Command Line Interface label Jun 11, 2026
@morri-son

Copy link
Copy Markdown
Contributor

looks ok from my side and should cover everything #1881 missed out.

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm marked this pull request as ready for review June 25, 2026 14:19
@frewilhelm frewilhelm requested a review from a team as a code owner June 25, 2026 14:19

@morri-son morri-son left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakobmoellerdev jakobmoellerdev merged commit 1634092 into open-component-model:main Jun 29, 2026
36 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ocm-cli OCM Command Line Interface kind/bugfix Bug size/m Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants