Skip to content

chore: add env-var gated repository-exist call#1996

Merged
frewilhelm merged 8 commits into
open-component-model:mainfrom
frewilhelm:transfer-workaround
Jun 17, 2026
Merged

chore: add env-var gated repository-exist call#1996
frewilhelm merged 8 commits into
open-component-model:mainfrom
frewilhelm:transfer-workaround

Conversation

@frewilhelm

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

We saw one failure of oci artifact transfers that we were not able to reproduce. We only know that reverting this change that was introduced by #1676 is fixing the issue. We do not want to revert it exactly because other users are using the concurrent workerpool and it just works fine. Hence, we introduced an environment variable gate, so users need to actively opt-in.

@github-actions github-actions Bot added kind/chore chore, maintenance, etc. size/s Small labels Jun 8, 2026
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm force-pushed the transfer-workaround branch from 1726fe4 to 71c6ef3 Compare June 15, 2026 06:47
@frewilhelm frewilhelm marked this pull request as ready for review June 16, 2026 11:01
@frewilhelm frewilhelm requested a review from a team as a code owner June 16, 2026 11:01
Comment thread api/tech/oras/pusher.go Outdated
matthiasbruns
matthiasbruns previously approved these changes Jun 16, 2026

@matthiasbruns matthiasbruns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to be too nit picky on this one

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm

Copy link
Copy Markdown
Contributor Author

no need to be too nit picky on this one

no, it was a fair point from both of you. I don't mind!

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Comment thread api/tech/oras/pusher.go Outdated
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm merged commit 33589f8 into open-component-model:main Jun 17, 2026
27 of 35 checks passed
@frewilhelm frewilhelm deleted the transfer-workaround branch June 18, 2026 06:44
frewilhelm added a commit that referenced this pull request Jun 18, 2026
…call (#1996) (#2010)

Cherry-pick of #1996 from main to releases/0.45, so the fix is available
for testing in the release candidate.

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/chore chore, maintenance, etc. size/s Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants